cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6206) JAASLoginInterceptor: Return proper unauthorized response when JAAS login with basic auth fails
Date Tue, 20 Jan 2015 15:09:38 GMT

    [ https://issues.apache.org/jira/browse/CXF-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283895#comment-14283895
] 

Sergey Beryozkin commented on CXF-6206:
---------------------------------------

As I said this code may affect the portability of the JAX-RS implementations across multiple
JAX-RS stacks.
Besides it is much more complex than the following code which does work in CXF with JAASLoginInterceptor

{code:java}
@Path("/")
public class MyResource {
@Context
private SecurityContext sc;
@GET
 @Path("/jaas/{echotoken}")
 @RolesAllowed("admin")
 public Response echo(@PathParam("echotoken") String message) {

	Token token = new Token(message);
	token.setPrincipal(sc.getUserPrincipal().getName());
	return Response.ok(token).build();

 }
}
{code}
 

> JAASLoginInterceptor: Return proper unauthorized response when JAAS login with basic
auth fails
> -----------------------------------------------------------------------------------------------
>
>                 Key: CXF-6206
>                 URL: https://issues.apache.org/jira/browse/CXF-6206
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core, Transports
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>             Fix For: 3.1.0
>
>
> Currently we return a Fault with a AuthenticationException when JAAS login fails.
> The proper response would be a 401 status with a suitable WWW-Authenticate header.
> I experimented with turning the AuthenticationException into a 401 response in the http
transport. Not sure where to take auth type and realm from though. I am also not sure how
to distinguish basic auth from WSS Security UsernameToken. As in the second case 401 is probably
not correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message