cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6161) wsdl2java can use invalid local filename when working with wsdl imports
Date Tue, 23 Dec 2014 13:12:13 GMT

    [ https://issues.apache.org/jira/browse/CXF-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256954#comment-14256954
] 

ASF GitHub Bot commented on CXF-6161:
-------------------------------------

Github user escabe commented on the pull request:

    https://github.com/apache/cxf/pull/43#issuecomment-67949395
  
    Ok, I could look into that. Before I do so however, do you have a preferred
    way of checking for valid file names in this project? Is doing a
    File.createNewFile() inside TRY-CATCH acceptable?
    
    On Thu, Dec 18, 2014 at 12:00 AM, Daniel Kulp <notifications@github.com>
    wrote:
    
    > If the file is a valid name, I would greatly prefer to keep the name.
    >
    > Also, one of the tests fails due to this. testClientJar fails due to:
    >
    >     assertTrue("hello_world_messages.wsdl is expected",
    >                  jarEntries.contains("hello_world_messages.wsdl"));
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cxf/pull/43#issuecomment-67413089>.
    >


> wsdl2java can use invalid local filename when working with wsdl imports
> -----------------------------------------------------------------------
>
>                 Key: CXF-6161
>                 URL: https://issues.apache.org/jira/browse/CXF-6161
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.7.14
>         Environment: Windows platform
>            Reporter: Martijn Aben
>
> When using wsdl2java on an WSDL which has an wsdl import like:
> <wsdl:import namespace="http://tempuri.org/MyService/ExternalWSDL" location="http://localhost/WebApplication1/WebService1.asmx?wsdl=wsdl1"/>
> WSDLToJavaContainer.generateLocalWSDL tries to create a temporary file on disk named
"WebService1.asmx?wsdl=wsdl1" on Windows this is an invalid filename due to the question mark
(?).
> I have a proposed solution for this: just like with schema imports simply use a numbered
file on disk importNN.wsdl. I will be submitting a pull request for this soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message