Return-Path: 
 <issues-return-32021-apmail-cxf-issues-archive=cxf.apache.org@cxf.apache.org>
X-Original-To: apmail-cxf-issues-archive@www.apache.org
Delivered-To: apmail-cxf-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B04421769B
	for <apmail-cxf-issues-archive@www.apache.org>;
 Fri, 31 Oct 2014 05:29:34 +0000 (UTC)
Received: (qmail 90310 invoked by uid 500); 31 Oct 2014 05:29:34 -0000
Delivered-To: apmail-cxf-issues-archive@cxf.apache.org
Received: (qmail 90268 invoked by uid 500); 31 Oct 2014 05:29:34 -0000
Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cxf.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cxf.apache.org>
List-Post: <mailto:issues@cxf.apache.org>
List-Id: <issues.cxf.apache.org>
Reply-To: dev@cxf.apache.org
Delivered-To: mailing list issues@cxf.apache.org
Received: (qmail 90256 invoked by uid 99); 31 Oct 2014 05:29:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Oct 2014 05:29:34 +0000
Date: Fri, 31 Oct 2014 05:29:34 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.12746722.1412777771000.380013.1414733374498@Atlassian.JIRA>
In-Reply-To: <JIRA.12746722.1412777771000@Atlassian.JIRA>
References: <JIRA.12746722.1412777771000@Atlassian.JIRA>
 <JIRA.12746722.1412777771707@arcas>
Subject: [jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain()
 can cause a build up of handler interceptors on the chain
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191390#comment-14191390 ] 

ASF GitHub Bot commented on CXF-6038:
-------------------------------------

Github user kylape commented on the pull request:

    https://github.com/apache/cxf/pull/25#issuecomment-61220541
  
    Okay, I reproduced the issue with CXF 3.0.2 and verified it is resolved in my build of the master branch today.  
    
    Just FYI -- in JBoss I only had to add this code:
    
    ```
    final Service service = Service.create(wsdl, ns);
    service.setHandlerResolver(new HandlerResolver() {
      public List<Handler> getHandlerChain(PortInfo info) {
        return handlerChain;
      }
    });
    ```
    
    because the JBossWS integration calls `setHandlerChain` for every invocation to ensure handler order (perhaps that could be improved upon as well?).  When using CXF without JBossWS integration, I had to call `((BindingProvider)port).getBinding().setHandlerChain(handlerChain)` for every invocation to reproduce the issue.


> Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
> -----------------------------------------------------------------------------------------------
>
>                 Key: CXF-6038
>                 URL: https://issues.apache.org/jira/browse/CXF-6038
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 3.0.1
>            Reporter: Kyle Lape
>            Assignee: Daniel Kulp
>             Fix For: 3.1.0, 3.0.3, 2.7.14
>
>
> If an interceptor chain is cached between invocations and a user calls {{setHandlerChain()}} before every invocation, the handler chain interceptors get added to the interceptor chain over and over indefinitely.  
> I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need to check for the presence of the handler interceptors on the chain already.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)