Return-Path: X-Original-To: apmail-cxf-issues-archive@www.apache.org Delivered-To: apmail-cxf-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E20521760F for ; Tue, 7 Oct 2014 06:33:35 +0000 (UTC) Received: (qmail 13171 invoked by uid 500); 7 Oct 2014 06:33:35 -0000 Delivered-To: apmail-cxf-issues-archive@cxf.apache.org Received: (qmail 13135 invoked by uid 500); 7 Oct 2014 06:33:35 -0000 Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list issues@cxf.apache.org Received: (qmail 13122 invoked by uid 99); 7 Oct 2014 06:33:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 06:33:35 +0000 Date: Tue, 7 Oct 2014 06:33:35 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cxf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CXF-5688) Problem Parsing FIQL Involving Enums MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CXF-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161542#comment-14161542 ] ASF GitHub Bot commented on CXF-5688: ------------------------------------- GitHub user azitabh opened a pull request: https://github.com/apache/cxf/pull/24 enhancing readability #CXF-5688 You can merge this pull request into a Git repository by running: $ git pull https://github.com/azitabh/cxf master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cxf/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 ---- commit c27f5fb93f9244882c590f6ffca97ac5c05a7e68 Author: Azitabh Ajit Date: 2014-10-07T06:31:22Z enhancing readability #CXF-5688 ---- > Problem Parsing FIQL Involving Enums > ------------------------------------ > > Key: CXF-5688 > URL: https://issues.apache.org/jira/browse/CXF-5688 > Project: CXF > Issue Type: Bug > Components: JAX-RS > Reporter: Azitabh > Assignee: Sergey Beryozkin > Priority: Minor > Fix For: 3.0.0, 2.7.12 > > > FIQL parser assumes that enums would be defined in all caps. > In case Enums are not defined in all caps, InjectionUtils.convertStringToPrimitive(String value, Class cls) raises PropertyNotFoundException because it's converting the user provided enum value to caps and calling ENUM.valueOf(UPPERCASE_STR). > ethod m = cls.getMethod("valueOf", new Class[]{String.class}); > return m.invoke(null, value.toUpperCase()); > Since JAVA doesn't enforce enums to be all caps, I don't see any reason why FIQLParser should assume this. > https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)