cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6038) Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on the chain
Date Fri, 31 Oct 2014 05:29:34 GMT

    [ https://issues.apache.org/jira/browse/CXF-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191390#comment-14191390
] 

ASF GitHub Bot commented on CXF-6038:
-------------------------------------

Github user kylape commented on the pull request:

    https://github.com/apache/cxf/pull/25#issuecomment-61220541
  
    Okay, I reproduced the issue with CXF 3.0.2 and verified it is resolved in my build of
the master branch today.  
    
    Just FYI -- in JBoss I only had to add this code:
    
    ```
    final Service service = Service.create(wsdl, ns);
    service.setHandlerResolver(new HandlerResolver() {
      public List<Handler> getHandlerChain(PortInfo info) {
        return handlerChain;
      }
    });
    ```
    
    because the JBossWS integration calls `setHandlerChain` for every invocation to ensure
handler order (perhaps that could be improved upon as well?).  When using CXF without JBossWS
integration, I had to call `((BindingProvider)port).getBinding().setHandlerChain(handlerChain)`
for every invocation to reproduce the issue.


> Repeatedly invoking setHandlerChain() can cause a build up of handler interceptors on
the chain
> -----------------------------------------------------------------------------------------------
>
>                 Key: CXF-6038
>                 URL: https://issues.apache.org/jira/browse/CXF-6038
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 3.0.1
>            Reporter: Kyle Lape
>            Assignee: Daniel Kulp
>             Fix For: 3.1.0, 3.0.3, 2.7.14
>
>
> If an interceptor chain is cached between invocations and a user calls {{setHandlerChain()}}
before every invocation, the handler chain interceptors get added to the interceptor chain
over and over indefinitely.  
> I'm guessing that {{JaxWsEndpointImpl.addHandlerInterceptors()}} would need to check
for the presence of the handler interceptors on the chain already.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message