cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tam Freestone-Bayes (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-5688) Problem Parsing FIQL Involving Enums
Date Mon, 06 Oct 2014 14:48:34 GMT

    [ https://issues.apache.org/jira/browse/CXF-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160354#comment-14160354
] 

Tam Freestone-Bayes commented on CXF-5688:
------------------------------------------

Thanks Sergey - looks good. For clarity, it might be worth changing

!MessageUtils.getContextualBoolean(m, ENUM_CONVERSION_CASE_SENSITIVE, false)

on line 1271 to:

MessageUtils.getContextualBoolean(m, ENUM_CONVERSION_CASE_SENSITIVE, true)

cheers,
tam

> Problem Parsing FIQL Involving Enums
> ------------------------------------
>
>                 Key: CXF-5688
>                 URL: https://issues.apache.org/jira/browse/CXF-5688
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>            Reporter: Azitabh
>            Assignee: Sergey Beryozkin
>            Priority: Minor
>             Fix For: 3.0.0, 2.7.12
>
>
> FIQL parser assumes that enums would be defined in all caps. 
> In case Enums are not defined in all caps, InjectionUtils.convertStringToPrimitive(String
value, Class<?> cls) raises PropertyNotFoundException because it's converting the user
provided enum value to caps and calling ENUM.valueOf(UPPERCASE_STR).
> ethod m  = cls.getMethod("valueOf", new Class[]{String.class});
> return m.invoke(null, value.toUpperCase());
> Since JAVA doesn't enforce enums to be all caps, I don't see any reason why FIQLParser
should assume this.
> https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message