cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-5938) LuceneQueryVisitor is not reusable / not thread-safe
Date Mon, 01 Sep 2014 14:59:21 GMT

    [ https://issues.apache.org/jira/browse/CXF-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117467#comment-14117467
] 

Sergey Beryozkin commented on CXF-5938:
---------------------------------------

Hi Andriy, 
FYI, I had to do a minor update to Lucene visitor as I was getting NPE in JAXRSClientServerTikaTest,
I just pushed down the state initialization down to visit(). 
I'd also like to build upon your earlier idea where you had two TL states and basically combine
it into one and have a closed/open state maintained, so that if the the same thread finds
a closed state it could safely reset it and as such it would be optional for users to call
reset(). It's a low level priority for me though, it all looks fine IMHO
Thanks, Sergey

> LuceneQueryVisitor is not reusable / not thread-safe
> ----------------------------------------------------
>
>                 Key: CXF-5938
>                 URL: https://issues.apache.org/jira/browse/CXF-5938
>             Project: CXF
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 3.0.1
>            Reporter: Andriy Redko
>            Assignee: Andriy Redko
>            Priority: Minor
>             Fix For: 3.0.2
>
>
> LuceneQueryVisitor class is not really reusable in current implementation: it keeps the
state of all parsed queries (which is generally fine) but it groups them by property name,
returning the first query from the list all the time. That means running two search criteria
like 'ct=java' and 'ct=websockets' causes the result of 'ct=java' to be returned in both cases
(very easy reproducible).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message