cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-5970) review org.apache.cxf.jaxrs.provider.ProviderFactory.Message*ReaderComparator
Date Mon, 25 Aug 2014 21:06:58 GMT

    [ https://issues.apache.org/jira/browse/CXF-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109730#comment-14109730
] 

Sergey Beryozkin commented on CXF-5970:
---------------------------------------

Right, I recall Jackson captures it all (returns true in isReadable AFAIK, if I recall it
right it has Consumes/Produces application/json ). The order of the registration must not
make a difference as far as selecting the right provider is concerned. Can you please give
me a more concrete example ? Say, you have Jackson provider and may be some other custom provider
for reading InputStream or some other type and Jackson takes it and then rejects ? Such issues
are expected to be fixed by having a CustomProvider<InputStream>, etc

Thanks, Sergey

> review org.apache.cxf.jaxrs.provider.ProviderFactory.Message*ReaderComparator
> -----------------------------------------------------------------------------
>
>                 Key: CXF-5970
>                 URL: https://issues.apache.org/jira/browse/CXF-5970
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Romain Manni-Bucau
>
> Actually the task can be rephrase saying rework org.apache.cxf.jaxrs.provider.ProviderFactory#*Comparators
> Current implementations don't seem to have an absolute order which means sorting is not
as deterministic as it should be under java >= 7.
> Other point is as a user you set a List of providers (you probably already sorted if
important) so you want to ensure *your* order is respected at runtime (ie org.apache.cxf.jaxrs.provider.ProviderFactory#message[Readers|Writers]
respect it).
> If you think this sorting is important maybe introducing in org.apache.cxf.jaxrs.AbstractJAXRSFactoryBean
and org.apache.cxf.jaxrs.provider.ProviderFactory a boolean sortProviders can be enough to
prevent calling sortXXX().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message