cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-5938) LuceneQueryVisitor is not reusable / not thread-safe
Date Fri, 29 Aug 2014 16:31:53 GMT

    [ https://issues.apache.org/jira/browse/CXF-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115410#comment-14115410
] 

Sergey Beryozkin commented on CXF-5938:
---------------------------------------

Hi Andriy

Thanks for starting working on it. 
Why does the visitor has 2 thread local states, this is something I do not understand, can
you please clarify ?

Cheers, Sergey 

> LuceneQueryVisitor is not reusable / not thread-safe
> ----------------------------------------------------
>
>                 Key: CXF-5938
>                 URL: https://issues.apache.org/jira/browse/CXF-5938
>             Project: CXF
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 3.0.1
>            Reporter: Andriy Redko
>            Assignee: Andriy Redko
>            Priority: Minor
>             Fix For: 3.0.2
>
>
> LuceneQueryVisitor class is not really reusable in current implementation: it keeps the
state of all parsed queries (which is generally fine) but it groups them by property name,
returning the first query from the list all the time. That means running two search criteria
like 'ct=java' and 'ct=websockets' causes the result of 'ct=java' to be returned in both cases
(very easy reproducible).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message