cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-5118) Create CXF interceptor which will use HTTPS client certificates to create JAAS SecurityContext
Date Sun, 03 Aug 2014 19:29:11 GMT

    [ https://issues.apache.org/jira/browse/CXF-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084103#comment-14084103
] 

Sergey Beryozkin commented on CXF-5118:
---------------------------------------

Hi, thanks for doing the refactoring, IMHO it will become better, this is why:

- in the original code people would have to extend JAASLoginInterceptor to customize the mapping
from Cert to a user name and we'd then only support a mappedName->password pairs. The pairs
in this psedo-form, fromCertificate->to Mappedname+password pairs would require reading
the properties file or db twice. Example, a file with "subjectName:mappedname,password" lines
would  require  read the file and get the mappedname and then read it again and get a password.

I think we agree on this now.

As far as your latest patch is concerned: it appears to be incomplete, CertificateMapper is
not used anywhere. 
As I suggested earlier: please move all the default mapping code to AbstractCertificateMapper,
the concrete mappers which are happy with the default implementations will extend it and provide
the password if any only.

Please also pass TLSSessionInfo or X5509Certificate array if you prefer to CertificateMapper
- the mappers may want to do the extra validation of the chain, and the chain might serve
as a secondary mapping key.
Finally, please return AuthorizationPolicy, or may be reuse UsernameToken or if you really
prefer introduce TLSUserToken, but I guess either  AuthorizationPolicy or UsernameToken would
do. The reason is, returning NamePasswordCallbackHandler might cause issues if a given JAAS
Login module does not work well with the default NamePasswordCallbackHandler implementation

Hope it makes sense, and that Chritian, others, agree too

Thanks for your effort :-)






> Create CXF interceptor which will use HTTPS client certificates to create JAAS SecurityContext

> -----------------------------------------------------------------------------------------------
>
>                 Key: CXF-5118
>                 URL: https://issues.apache.org/jira/browse/CXF-5118
>             Project: CXF
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sergey Beryozkin
>            Assignee: Christian Schneider
>
> Use case:
> The user authenticates against the webservice using an X509 client certificate. In case
of successful authentication the JAAS security context should be populated with a Subject
that stores the user name and the roles of the user. This is necessary to support Authorization
at a later stage.
> Design ideas
> The SSL transport will be configured to only accept certain client certificates. So we
can assume that the interceptor does not have to do a real authentication. Instead it has
to map from the subjectDN of the certificate to the user name and then lookup the roles of
that user. Both then has to be stored in the subject's principles.
> The mapping could be done inside a JAASLoginModule or before. Inside will give the user
more flexibility.
> The next step to retrieve the roles should be done in one of the standard JAASLoginModules
as the source of the roles can be quite diverse. So for example the LdapLoginModule allows
to retrieve the roles from Ldap. At the moment these modules require the password of the user
though which is not available when doing a cert based auth.
> So I see two variants to retrieve the roles:
> 1. Change the loginmodules like the LDAP one to be configureable to use a fixed ldap
user for the ldap connect and not require the user password. So the module would have two
modes: a) normal authentication and group gathering b) use a fixed user to just retrieve roles
for a given user
> 2. Store the user password somewhere (e.g. in the mapping file). In this case the existing
LDAPLoginModule could be used but the user password would be openly in a text file
> 3. Create new LoginModules with the desired behaviour (fixed user and only lookup of
roles)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message