Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Tue, 15 Apr 2014 12:54:19 +0000 (UTC)
From: "Sergey Beryozkin (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.12708243.1397477957464.117176.1397566459172@arcas>
In-Reply-To: <JIRA.12708243.1397477957464@arcas>
References: <JIRA.12708243.1397477957464@arcas>
Subject: [jira] [Commented] (CXF-5688) Problem Parsing FIQL Involving Enums
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CXF-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969505#comment-13969505 ] 

Sergey Beryozkin commented on CXF-5688:
---------------------------------------

Well, the case where we have enum with say "GOOD" and "PERFECT" values and a query like "status=good" is more realistic to deal with; having a "Good" enum value and thus expecting the query contain a strictly case sensitive value such as "status=Good" is a bit more brittle in case of enums unless the client side is controlled. However I can imagine where the existing enums which can not be modified may need to be supported, as such a contextual property can be introduced to support this edge case. The property name is "enum.conversion.case.sensitive"

> Problem Parsing FIQL Involving Enums
> ------------------------------------
>
>                 Key: CXF-5688
>                 URL: https://issues.apache.org/jira/browse/CXF-5688
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Azitabh
>            Priority: Critical
>
> FIQL parser assumes that enums would be defined in all caps. 
> In case Enums are not defined in all caps, InjectionUtils.convertStringToPrimitive(String value, Class<?> cls) raises PropertyNotFoundException because it's converting the user provided enum value to caps and calling ENUM.valueOf(UPPERCASE_STR).
> ethod m  = cls.getMethod("valueOf", new Class[]{String.class});
> return m.invoke(null, value.toUpperCase());
> Since JAVA doesn't enforce enums to be all caps, I don't see any reason why FIQLParser should assume this.
> https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java 


--
This message was sent by Atlassian JIRA
(v6.2#6252)