cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-5508) Bug CXF-4231 is back since 2.7.6
Date Fri, 24 Jan 2014 17:19:46 GMT

    [ https://issues.apache.org/jira/browse/CXF-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881164#comment-13881164
] 

Sergey Beryozkin commented on CXF-5508:
---------------------------------------

Hi Jan,

I've looked at http://tools.ietf.org/search/draft-ietf-httpbis-p4-conditional-25#section-3.1.
So,
" When a client desires to update one or more
   stored responses that have entity-tags, the client SHOULD generate an
   If-None-Match header field containing a list of those entity-tags
   when making a GET request; this allows recipient servers to send a
   304 (Not Modified) response to indicate when one of those stored
   responses *matches* the selected representation."

In other words, the server sends a new representation if we have no matches.
I think it is correct, right ?

In your case you do have tags matching. And ResponseImpl.evaluateIfNonMatch() returns null
to indicate a match which is wrong, if we have a match in If-None-Match case then it means
we do need a non-null ResponseBuilder to suggest that no resources have been modified. So
I think you are right, the only thing is that the fix needs to be done inside ResponseImpl.evaluateIfNonMatch(),
it should return the opposite value of the matching result...  

Thanks, Sergey

> Bug CXF-4231 is back since 2.7.6
> --------------------------------
>
>                 Key: CXF-5508
>                 URL: https://issues.apache.org/jira/browse/CXF-5508
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.7.6
>            Reporter: Jan Engehausen
>
> The problem I reported in https://issues.apache.org/jira/browse/CXF-4231 is back since
2.7.6; we noticed when upgrading to 2.7.8. See also https://fisheye6.atlassian.com/browse/cxf/branches/2.7.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/RequestImpl.java?r2=1503661&r=1494596
> The concrete change/problematic part: if (rb != null) { => if (rb == null) {
> Any chance for a fix in the next release?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message