cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <>
Subject [jira] [Commented] (CXF-5508) Bug CXF-4231 is back since 2.7.6
Date Wed, 22 Jan 2014 11:51:23 GMT


Sergey Beryozkin commented on CXF-5508:

I'm pretty the last change came after I did some TCK work,

So we have
public ResponseBuilder evaluatePreconditions(Date lastModified, EntityTag eTag) {
        final ResponseBuilder rb = evaluatePreconditions(eTag);
        if (rb == null) {
            // the ETag conditions match; so now conditions for last modified must match
            return evaluatePreconditions(lastModified);
        } else {
            // the ETag conditions do not match, so last modified should be ignored
            // see (section 14.26 for
            // "If-None-Match", behaviour not specified for "If-Match", section 14.24)
            return null;

and the relevant text:

"If none of the entity tags match, then the server MAY perform the requested method as if
the If-None-Match header field did not exist, but MUST also ignore any If-Modified-Since header
field(s) in the request. That is, *if no entity tags match, then the server MUST NOT return
a 304 (Not Modified) response*."

The code above will ignore If-Modified-Since if none of the entity tags match, i.e, if they
match, ResponseBuilder is not null, and the dates are checked, but of they do not match then
null is returned.
Where is the problem ?


> Bug CXF-4231 is back since 2.7.6
> --------------------------------
>                 Key: CXF-5508
>                 URL:
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.7.6
>            Reporter: Jan Engehausen
> The problem I reported in is back since
2.7.6; we noticed when upgrading to 2.7.8. See also
> The concrete change/problematic part: if (rb != null) { => if (rb == null) {
> Any chance for a fix in the next release?

This message was sent by Atlassian JIRA

View raw message