cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-5508) Request.evaluatePreconditions(Date, EntityTag) loses a non-null ResponseBuilder
Date Mon, 27 Jan 2014 12:45:38 GMT

    [ https://issues.apache.org/jira/browse/CXF-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882790#comment-13882790
] 

Sergey Beryozkin commented on CXF-5508:
---------------------------------------

Hi Jan,
I think in this case you have to use a single parameter method,

http://docs.oracle.com/javaee/6/api/javax/ws/rs/core/Request.html#evaluatePreconditions(javax.ws.rs.core.EntityTag)

otherwise, if we did it as per your suggestion then in the method accepting two parameters,
Date *will never be used*. In fact, I'm not seeing anything like "MUST NOT" in the latest
HTTP spec effort:
http://tools.ietf.org/search/draft-ietf-httpbis-p4-conditional-25#section-6

I think all is good now. If you do not want to use a secondary Date check then simply do Request.evaluatePreconditions(EntityTag)

Thanks, Sergey



> Request.evaluatePreconditions(Date, EntityTag) loses a non-null ResponseBuilder 
> --------------------------------------------------------------------------------
>
>                 Key: CXF-5508
>                 URL: https://issues.apache.org/jira/browse/CXF-5508
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.7.6
>            Reporter: Jan Engehausen
>            Assignee: Sergey Beryozkin
>             Fix For: 3.0.0-milestone2, 2.6.12, 2.7.9
>
>
> The problem I reported in https://issues.apache.org/jira/browse/CXF-4231 is back since
2.7.6; we noticed when upgrading to 2.7.8. See also https://fisheye6.atlassian.com/browse/cxf/branches/2.7.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/RequestImpl.java?r2=1503661&r=1494596
> The concrete change/problematic part: if (rb != null) { => if (rb == null) {
> Any chance for a fix in the next release?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message