cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Bellassai (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CXF-5078) WSDLGetInterceptor holds a lock for too long
Date Thu, 13 Jun 2013 20:53:19 GMT

     [ https://issues.apache.org/jira/browse/CXF-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

John Bellassai updated CXF-5078:
--------------------------------

    Attachment: my.patch

Patch for WSDLGetInterceptor
                
> WSDLGetInterceptor holds a lock for too long
> --------------------------------------------
>
>                 Key: CXF-5078
>                 URL: https://issues.apache.org/jira/browse/CXF-5078
>             Project: CXF
>          Issue Type: Bug
>          Components: Simple Frontend
>    Affects Versions: 2.5.10, 2.6.8, 2.7.5
>            Reporter: John Bellassai
>              Labels: patch
>             Fix For: 2.5.11, 2.6.9, 2.7.6
>
>         Attachments: my.patch
>
>
> WSDLGetInterceptor both creates the WSDL Document object and writes that data to the
OutputStream while holding onto a lock.  This can cause major issues in an environment where
that data is being sent to very slow clients or there are other general networking issues.
> We have seen this problem manifest multiple times in a production environment where all
of Tomcat's connection handler threads pile up while waiting for this lock to become available
because it is being held by a thread which is trying to write to a socket but cannot for whatever
reason.  Eventually Tomcat stops responding to new requests and must be bounced.
> Daniel Kulp suggested that instead of writing the WSDL Document directly to the OutputStream
from the message, rather write it to a CachedOutputStream while holding the lock. Then outside
of the synchronized block, copy it from the CachedOutputStream to the real OutputStream to
the client.  In this way, a single bad connection or slow client cannot cause trouble for
others.
> I will attach a patch made against the lastest WSDLGetInterceptor from 2.7.6-SNAPSHOT.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message