cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dario Amiri (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CXF-5048) StaticSTSProperties class requires a CXF message context to initialize using configure() method
Date Wed, 29 May 2013 20:28:20 GMT
Dario Amiri created CXF-5048:
--------------------------------

             Summary: StaticSTSProperties class requires a CXF message context to initialize
using configure() method
                 Key: CXF-5048
                 URL: https://issues.apache.org/jira/browse/CXF-5048
             Project: CXF
          Issue Type: Bug
    Affects Versions: 2.7.3
         Environment: OSX, Karaf 2.2.9, CXF 2.7.3, Camel 2.10.2, Jetty 7.6.7.v20120910, Karaf-Jetty
7.5.4.v20111024
            Reporter: Dario Amiri


On May 29, 2013, at 12:47 PM, geecxf <[hidden email]> wrote:

> While experimenting with the STS code I discovered that configureProperties()
> method of the StaticSTSProperties class requires a CXF message context in
> order to execute successfully.
>
> This seems a little strange to me because as far as I understand the
> properties are set once and there is nothing about them is related to the
> request context. The way it is implemented now you basically have to wait
> until the service is invoked before you can initialize the properties. Is
> there a reason why it was implemented this way?
>
> I ask because it just doesn't seem right. I would expect to be able to call
> configureProperties() at some point in time before the service was invoked.
... [show rest of quote]

This definitely looks like a bug.  In there, if the various properties objects are String's,
then we end up doing:

 Bus bus = PhaseInterceptorChain.getCurrentMessage().getExchange().getBus();
            ResourceManager rm = bus.getExtension(ResourceManager.class);

to get a ResourceManager to try and resolve those.   Most likely, we should do:

1) Allow setting a Bus object on the properties so that the actual bus used is settable.

2) If bus is null, call BusFactory.getThreadDefaultBus() instead.  

Please log a bug.

Dan 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message