Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Wed, 24 Apr 2013 15:03:16 +0000 (UTC)
From: "Sergey Beryozkin (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.12638843.1364206121195.216449.1366815796082@arcas>
In-Reply-To: <JIRA.12638843.1364206121195@arcas>
References: <JIRA.12638843.1364206121195@arcas>
Subject: [jira] [Commented] (CXF-4919) UriInfo.relativize (and
 HttpUtils.relativize) broken
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CXF-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640519#comment-13640519 ] 

Sergey Beryozkin commented on CXF-4919:
---------------------------------------

Hi, looks like I've got it, see the example at the end of my last comment. I'll support JAX_RS_SPEC-398, that can be fixed for 2.1.


> UriInfo.relativize (and HttpUtils.relativize) broken
> ----------------------------------------------------
>
>                 Key: CXF-4919
>                 URL: https://issues.apache.org/jira/browse/CXF-4919
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.7.3
>            Reporter: Stian Soiland-Reyes
>
> None of these tests pass:
> {code}
>   
>     @Test
>     public void testRelativize() throws Exception {
>         URI ab = URI.create("http://example.com/a/b/");
>         URI abcd = URI.create("http://example.com/a/b/c/d");
>         assertEquals(URI.create(""), HttpUtils.relativize(ab, ab));
>         assertEquals(URI.create("c/d"), HttpUtils.relativize(ab, abcd));
>         assertEquals(URI.create("../"), HttpUtils.relativize(abcd, ab));
>         assertEquals(URI.create(""), HttpUtils.relativize(abcd, abcd));
>         URI abcd2 = URI.create("http://example.com/a/b/c/d2");
>         assertEquals(URI.create("d2"), HttpUtils.relativize(abcd, abcd2));
>         URI ab2cd = URI.create("http://example.com/a/b2/c/d");
>         assertEquals(URI.create("../../b2/c/d"), HttpUtils.relativize(abcd, ab2cd));
>     }
> {code}
> This affects LinkBuilder.buildRelativize() and UriInfo.relativize()
> The algorithm is basically working by counting elements common by position - this would also fail hard when there are common elements later - but with a different ancestor.
> Javadoc for UriInfo.relativize() also has some testcases that should work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira