cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stian Soiland-Reyes (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-4919) UriInfo.relativize (and HttpUtils.relativize) broken
Date Mon, 22 Apr 2013 01:30:13 GMT

    [ https://issues.apache.org/jira/browse/CXF-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637718#comment-13637718
] 

Stian Soiland-Reyes commented on CXF-4919:
------------------------------------------

I've reported the misleading JAX-RS javadoc at https://java.net/jira/browse/JAX_RS_SPEC-398
-- but as JAX-RS is scheduled for release tomorrow (!) 2013-04-23 we might end up in a confusing
situation where we would have to choose between following the specification of JAX-RS or generate
URI references that are correct for the rest of the world.
                
> UriInfo.relativize (and HttpUtils.relativize) broken
> ----------------------------------------------------
>
>                 Key: CXF-4919
>                 URL: https://issues.apache.org/jira/browse/CXF-4919
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.7.3
>            Reporter: Stian Soiland-Reyes
>
> None of these tests pass:
> {code}
>   
>     @Test
>     public void testRelativize() throws Exception {
>         URI ab = URI.create("http://example.com/a/b/");
>         URI abcd = URI.create("http://example.com/a/b/c/d");
>         assertEquals("", HttpUtils.relativize(ab, ab));
>         assertEquals(URI.create("c/d"), HttpUtils.relativize(ab, abcd));
>         assertEquals(URI.create("../"), HttpUtils.relativize(abcd, ab));
>         assertEquals("", HttpUtils.relativize(abcd, abcd));
>         URI abcd2 = URI.create("http://example.com/a/b/c/d2");
>         assertEquals(URI.create("d2"), HttpUtils.relativize(abcd, abcd2));
>         URI ab2cd = URI.create("http://example.com/a/b2/c/d");
>         assertEquals(URI.create("../../b2/c/d"), HttpUtils.relativize(abcd, ab2cd));
>     }
> {code}
> This affects LinkBuilder.buildRelativize() and UriInfo.relativize()
> The algorithm is basically working by counting elements common by position - this would
also fail hard when there are common elements later - but with a different ancestor.
> Javadoc for UriInfo.relativize() also has some testcases that should work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message