cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glen Mazza (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FEDIZ-25) Look for fediz_config.xml in catalina base too
Date Mon, 27 Aug 2012 13:28:07 GMT

    [ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442403#comment-13442403
] 

Glen Mazza edited comment on FEDIZ-25 at 8/28/12 12:27 AM:
-----------------------------------------------------------

Hi, couple of issues with the patch:

1.) To reduce confusion, the name of the local variable at line #144 should be changed to
"String catalinaBase", not "catalinaHome" anymore, as the former will equal the latter if
the former isn't explicitly defined (http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Introduction),
so catalinaBase is the way to go.  We're always reading from catalinaBase (which will always
have a value), so that's the appropriate name for the value.

2.) I don't like the change in the first half of your patch, around line #105 -- you read
from catalinaBase iff catalinaHome is not producing a valid file.  That logic seems wrong,
catalinaBase must have precedence for configuration files, see "Advanced Configuration - Multiple
Tomcat Instances" section here: http://tomcat.apache.org/tomcat-7.0-doc/RUNNING.txt, "conf"
section.  That same section implies that $CATALINA_HOME/conf folder is *not* searched if it
is not found in $CATALINA_BASE/conf, however the Tomcat team is wishy-washy on that (http://tomcat.10.n6.nabble.com/CATALINA-BASE-and-CATALINA-HOME-deployment-tp4981258p4981264.html).
 Whether or not we should attempt to read from $CATALINA_HOME/conf if it's not already present
in $CATALINA_BASE/conf (where CATALINA_HOME != CATALINA_BASE), I have no strong opinion on
either way.

Thanks!
                
      was (Author: gmazza):
    Hi, couple of issues with the patch:

1.) To reduce confusion, the name of the local variable at line #144 should be changed to
"String catalinaBase", not "catalinaHome" anymore, as the former will equal the latter if
the former isn't explicitly defined (http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Introduction),
so catalinaBase is the way to go.  We're always reading from catalinaBase (which will always
have a value), so that's the appropriate name for the value.

2.) I don't like the change in the first half of your patch, around line #105 -- you read
from catalinaBase iff catalinaHome is not producing a valid file--that logic seems wrong,
catalinaBase must have precedence for configuration files--see "Advanced Configuration - Multiple
Tomcat Instances" section here: http://tomcat.apache.org/tomcat-7.0-doc/RUNNING.txt, "conf"
section.  That same section implies that $CATALINA_HOME/conf folder is *not* searched if it
is not found in $CATALINA_BASE/conf, however the Tomcat team is wishy-washy on that (http://tomcat.10.n6.nabble.com/CATALINA-BASE-and-CATALINA-HOME-deployment-tp4981258p4981264.html).
 Whether or not we should attempt to read from $CATALINA_HOME/conf if it's not already present
in $CATALINA_BASE/conf (where CATALINA_HOME != CATALINA_BASE), I have no strong opinion on
either way.

Thanks!
                  
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
>                 Key: FEDIZ-25
>                 URL: https://issues.apache.org/jira/browse/FEDIZ-25
>             Project: CXF-Fediz
>          Issue Type: Improvement
>          Components: Plugin
>    Affects Versions: 1.0.0, 1.0.1
>            Reporter: Juan Manuel CABRERA
>            Priority: Trivial
>         Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home
only, it should be fetched in the catalina_base too to address the cases where both variables
are different (which is the case with WTP by default for instance, or in many production deployment)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message