Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Wed, 4 Apr 2012 19:52:18 +0000 (UTC)
From: =?utf-8?Q?Andreas_Kr=C3=BCger_=28Updated=29_=28JIRA=29?=
 <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: 
 <975048100.13687.1333569138942.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <459098391.13669.1333568898705.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (CXF-4227) AttachmentDeserializerTest contains
 buggy code for reading an InputStream.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/CXF-4227?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kr=C3=BCger updated CXF-4227:
--------------------------------

    Attachment: AttachmentDeserializerTest.patch

The patch I promised.
               =20
> AttachmentDeserializerTest contains buggy code for reading an InputStream=
.
> -------------------------------------------------------------------------=
-
>
>                 Key: CXF-4227
>                 URL: https://issues.apache.org/jira/browse/CXF-4227
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>            Reporter: Andreas Kr=C3=BCger
>            Priority: Minor
>              Labels: patch
>         Attachments: AttachmentDeserializerTest.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Browsing through the CXF code, I stumbled over the following in Attachmen=
tDeserializerTest, method testCXF3383():
> {code}
> for (int x =3D 1; x < 50; x++) {
>     String cid =3D "1882f79d-e20a-4b36-a222-7a75518cf395-" + x + "@cxf.ap=
ache.org";
>     DataSource ds =3D AttachmentUtil.getAttachmentDataSource(cid, message=
.getAttachments());
>     byte bts[] =3D new byte[1024];
>            =20
>     InputStream ins =3D ds.getInputStream();
>     int count =3D ins.read(bts, 0, bts.length);
>     int sz =3D ins.read(bts, count, bts.length - count);
>     while (sz !=3D -1) {
>         sz =3D ins.read(bts, count, bts.length - count);
>     }
>     assertEquals(x + 1, count);
> }
> {code}
> I think some "count +=3D sz" has been forgotten. Details:
> * The while-loop does nothing to change the test result.
> * Endless loop, should "ins" ever deliver 1025 bytes or more.
> * The fix is obvious, I'll attach a patch.
> The problem does not show as long as "ins" contains less than 1024 bytes =
and all its content is delivered with the first read operation. So no funct=
ional impairment, just code hygiene.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira