Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Mon, 26 Mar 2012 14:48:28 +0000 (UTC)
From: "Daniel Kulp (Commented) (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: 
 <299108168.17581.1332773308771.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1220223275.12622.1330707597280.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CXF-4154) AbstractConduitSelector reused cached
 conduit even if protocol was changed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CXF-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238446#comment-13238446 ] 

Daniel Kulp commented on CXF-4154:
----------------------------------

Committed a fix last night that pretty much removes the "selectedConduit" field and keeps a list of conduits.  Under normal operation, that's a single conduit, but it can "grow" as additional protocols and such require it.

Because of the field removal, not back portable to <=2.5.x.   Will need to be release noted.

Can you give it a quick spin to make sure it works OK?
                
> AbstractConduitSelector reused cached conduit even if protocol was changed
> --------------------------------------------------------------------------
>
>                 Key: CXF-4154
>                 URL: https://issues.apache.org/jira/browse/CXF-4154
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>            Reporter: Andrei Shakirin
>         Attachments: AbstractConduitSelector.patch
>
>
> Hi,
> Actually AbstractConduitSelector.getSelectedConduit() creates and caches conduit in selectedConduit variable. Cached conduit is reused by the next calls.
> I see the following problem: if user changed protocol in URI between calls, AbstractConduitSelector still uses cached Conduit even it cannot process new URL. In my case cached HTTP consuit tries to process UDP URL.
> Proposal for fix: check if protocol in URL was changed and if yes, close and reset selectedConduit.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira