cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-4071) LoggingInterceptors contain parts which are not nessecary.
Date Fri, 27 Jan 2012 16:48:13 GMT

    [ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194908#comment-13194908
] 

Sergey Beryozkin commented on CXF-4071:
---------------------------------------

Ok, after commenting a lot I've read it again, as usual :-).

Michael, sorry, I missed your point from the start.

Seeing the request HTTP method being output by LoggingOutInterceptor on the server side may
be still useful for some additional 'context', but I agree it may be redundant, given that
LoggingInInterceptor has already showed it.

So scoping it with the isRequestor() as suggested by Dan sounds good.

As for the response code, LoggingInInterceptor (on the client side) needs to show it IMHO,
with Christian also saying it's conditional if the response code is set.

So, I'm sorry for a noise :-), 
Cheers




                
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
>                 Key: CXF-4071
>                 URL: https://issues.apache.org/jira/browse/CXF-4071
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.5.2
>            Reporter: Michael PrieƟ
>            Assignee: Christian Schneider
>         Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message