cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Kulp (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-4071) LoggingInterceptors contain parts which are not nessecary.
Date Fri, 27 Jan 2012 14:48:11 GMT

    [ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194804#comment-13194804
] 

Daniel Kulp commented on CXF-4071:
----------------------------------


These interceptors are also used on the Client side.   On the client side, on the incoming
message, knowing the response code is important as that can help diagnose what the chains
are doing, what the REST server did, etc....    On outgoing, the METHOD is important, especially
for REST where the METHOD is an extremely important part about what the request is doing.

I would not remove them.   However, it could be put into a MessageUtils.isRequestor(...) block.




                
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
>                 Key: CXF-4071
>                 URL: https://issues.apache.org/jira/browse/CXF-4071
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.2
>            Reporter: Michael PrieƟ
>            Assignee: Christian Schneider
>         Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message