cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-4071) LoggingInterceptors contain parts which are not nessecary.
Date Fri, 27 Jan 2012 16:12:09 GMT

    [ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194883#comment-13194883
] 

Christian Schneider commented on CXF-4071:
------------------------------------------

I just looked at the new patch. I think it is not necessary to check witth the isRequestor.
The check if e.g. the response code is set is good enough. If the response code is set it
makes sense to log it. So I think there is no need to change anything. 

Sorry that I did not see this earlier? Do you guys agree? Well if nothing more this at least
got Michael to submit his first patch to CXF :-)

                
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
>                 Key: CXF-4071
>                 URL: https://issues.apache.org/jira/browse/CXF-4071
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.5.2
>            Reporter: Michael PrieƟ
>            Assignee: Christian Schneider
>         Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message