Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Wed, 7 Dec 2011 17:32:41 +0000 (UTC)
From: "Daniel Kulp (Resolved) (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: 
 <1745335137.50010.1323279161668.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1306836217.49377.1323266321132.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Resolved] (CXF-3961) SoapTransportFactory: confused
 exception by unknown transport protocol
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CXF-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-3961.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.5.1
                   2.4.5
                   2.3.8


Patch  applied.   Thanks!

                
> SoapTransportFactory: confused exception by unknown transport protocol
> ----------------------------------------------------------------------
>
>                 Key: CXF-3961
>                 URL: https://issues.apache.org/jira/browse/CXF-3961
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5
>         Environment: Windows
>            Reporter: Andrei Shakirin
>            Assignee: Daniel Kulp
>            Priority: Minor
>             Fix For: 2.3.8, 2.4.5, 2.5.1
>
>         Attachments: SoapTransportFactory.patch
>
>
> If custom transport conduit is resolved via SoapTransportFactory.getConduit(EndpointInfo ei) and transport is not found in ConduitInitiatorManager, following exception is thrown:
> java.lang.NullPointerException
>         at org.apache.cxf.binding.soap.SoapTransportFactory.getConduit(SoapTransportFactor
> y.java:228)[131:org.apache.cxf.bundle:2.4.2]
> The reason is following: ConduitInitiatorManager.getConduitInitiatorForUri() doesn't throw BusException in case if transport is not found, therefore line "return conduitInit.getConduit(ei)" throws NPE.
> I see two possible solutions:
> A) throw BusException in ConduitInitiatorManager.getConduitInitiatorForUri() in the same way as ConduitInitiatorManager.getConduitInitiator()
> B) Check for null in SoapTransportFactory
> (A) is risky, because it has invluence on all calls of ConduitInitiatorManager.getConduitInitiatorForUri()
> Patch for (B) is attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira