cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CXF-3790) org.apache.cxf.jaxws.interceptors.WrapperClassInInterceptor.handleMessage(Message) contains cruft code
Date Fri, 02 Sep 2011 14:58:09 GMT

     [ https://issues.apache.org/jira/browse/CXF-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary D. Gregory updated CXF-3790:
---------------------------------

    Attachment: WrapperClassInInterceptor.diff

trunk patch

> org.apache.cxf.jaxws.interceptors.WrapperClassInInterceptor.handleMessage(Message) contains
cruft code
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3790
>                 URL: https://issues.apache.org/jira/browse/CXF-3790
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.2
>         Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\Java\apache-maven-3.0.3\bin\..
> Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_24\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>            Reporter: Gary D. Gregory
>         Attachments: WrapperClassInInterceptor.diff
>
>
> While debugging our server, in {{org.apache.cxf.jaxws.interceptors.WrapperClassInInterceptor.handleMessage(Message)}}
I saw:
> {code:java}
>             MessageContentsList lst = MessageContentsList.getContentsList(message);
>             if (lst == null) {
>                 return;
>             }
>             if (lst != null) {
>                 message.put(MessageInfo.class, messageInfo);
>                 message.put(BindingMessageInfo.class, bmi);
>                 ex.put(BindingOperationInfo.class, boi2);
>                 ex.put(OperationInfo.class, op);
>             }
> {code}
> Offering patch to redo as:
> {code:java}
>             MessageContentsList lst = MessageContentsList.getContentsList(message);
>             if (lst == null) {
>                 return;
>             }
>             message.put(MessageInfo.class, messageInfo);
>             message.put(BindingMessageInfo.class, bmi);
>             ex.put(BindingOperationInfo.class, boi2);
>             ex.put(OperationInfo.class, op);
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message