Return-Path: 
 <issues-return-17320-apmail-cxf-issues-archive=cxf.apache.org@cxf.apache.org>
X-Original-To: apmail-cxf-issues-archive@www.apache.org
Delivered-To: apmail-cxf-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 11C934CB9
	for <apmail-cxf-issues-archive@www.apache.org>;
 Wed,  8 Jun 2011 06:26:25 +0000 (UTC)
Received: (qmail 86465 invoked by uid 500); 8 Jun 2011 06:26:25 -0000
Delivered-To: apmail-cxf-issues-archive@cxf.apache.org
Received: (qmail 86394 invoked by uid 500); 8 Jun 2011 06:26:22 -0000
Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cxf.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cxf.apache.org>
List-Post: <mailto:issues@cxf.apache.org>
List-Id: <issues.cxf.apache.org>
Reply-To: dev@cxf.apache.org
Delivered-To: mailing list issues@cxf.apache.org
Received: (qmail 86384 invoked by uid 99); 8 Jun 2011 06:26:19 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2011 06:26:19 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2011 06:26:18 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id D65E2107839
	for <issues@cxf.apache.org>; Wed,  8 Jun 2011 06:25:58 +0000 (UTC)
Date: Wed, 8 Jun 2011 06:25:58 +0000 (UTC)
From: "Oliver Wulff (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: 
 <775213039.2400.1307514358874.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <806934911.1333.1307480938844.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (CXF-3576) Potential overflow for lifetime
 calculation in STSClient
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/CXF-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Wulff updated CXF-3576:
------------------------------

    Attachment: STSClient.patch

I've updated the patch and attached again.

I used the following tool to create the patch:
diff -crB <old> <new>


> Potential overflow for lifetime calculation in STSClient
> --------------------------------------------------------
>
>                 Key: CXF-3576
>                 URL: https://issues.apache.org/jira/browse/CXF-3576
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.4
>            Reporter: Oliver Wulff
>             Fix For: 2.4.1
>
>         Attachments: STSClient.patch, patch.diff
>
>
> This code performs integer multiply and then converts the result to a long:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000));
> Fix:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000L));

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira