cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Freeman Fang (JIRA)" <>
Subject [jira] [Commented] (CXF-3558) JaxWsProxyFactoryBean.create is not thread-safe
Date Wed, 01 Jun 2011 06:37:48 GMT


Freeman Fang commented on CXF-3558:

Hi Tomasz,

Btw, your blog about "Enabling load balancing and failover in Apache CXF" is really good,
I've added the link to cxf resources and articles list.


> JaxWsProxyFactoryBean.create is not thread-safe
> -----------------------------------------------
>                 Key: CXF-3558
>                 URL:
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4
>            Reporter: Tomasz Nurkiewicz
>            Assignee: Freeman Fang
>             Fix For: 2.4.1, 2.3.5
>         Attachments: CXF-3558.txt
> While running {{JaxWsProxyFactoryBean.create}} concurrently I encountered the following
> {code}Caused by: java.util.ConcurrentModificationException
> 	at java.util.LinkedList$ListItr.checkForComodification(
> 	at java.util.LinkedList$
> 	at org.apache.cxf.service.factory.AbstractServiceFactoryBean.sendEvent(
> 	at org.apache.cxf.service.factory.ReflectionServiceFactoryBean.create(
> 	at
> 	at org.apache.cxf.frontend.AbstractWSDLBasedEndpointFactory.createEndpoint(
> 	at org.apache.cxf.frontend.ClientFactoryBean.create(
> 	at org.apache.cxf.frontend.ClientProxyFactoryBean.create(
> 	at org.apache.cxf.jaxws.JaxWsProxyFactoryBean.create(
> {code}
> Although not documented (?), {{org.apache.cxf.service.factory.ReflectionServiceFactoryBean#create}}
called somewhere during endpoint creation is {{synchronized}} which suggests whole {{create}}
is thread-safe, but apparently it's not.
> I managed to discover source of this problem. I captured two threads: one ({{pool-1-thread-4}})
entered synchronized {{ReflectionServiceFactoryBean#create}}, the second one ({{pool-1-thread-2}})
didn't made there yet but instead it calls {{AbstractServiceFactoryBean.setBus}} outside of
the {{synchronized}} block. This causes the {{org.apache.cxf.service.factory.AbstractServiceFactoryBean#listeners}}
to be updated, making the former thread being susceptible to {{ConcurrentModificationException}}.
Stack dumps attached.
> Please either fix concurrency issue (making {{listeners}} instance of {{java.util.concurrent.CopyOnWriteArrayList}}
might not be enough though) or document that {{JaxWsProxyFactoryBean.create}} is not thread-safe.

This message is automatically generated by JIRA.
For more information on JIRA, see:

View raw message