cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Freeman Fang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-3546) Warning message in ReflectionServiceFactoryBean should be INFO level
Date Wed, 25 May 2011 05:58:47 GMT

    [ https://issues.apache.org/jira/browse/CXF-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038972#comment-13038972
] 

Freeman Fang commented on CXF-3546:
-----------------------------------

Hi,

This code is in simple front end, the simple front end generally means you needn't use annotations
in the code, so the WARNING message here actually warn you that you kind of misuse the simple
front end as you have jaxws annotations, in which case you may need consider to use jaxws
frontend instead.

Freeman 

> Warning message in ReflectionServiceFactoryBean should be INFO level
> --------------------------------------------------------------------
>
>                 Key: CXF-3546
>                 URL: https://issues.apache.org/jira/browse/CXF-3546
>             Project: CXF
>          Issue Type: Bug
>          Components: Core, JAX-WS Runtime
>            Reporter: David Liu
>            Assignee: Freeman Fang
>            Priority: Minor
>
> Hi, 
>   Can we change log level *LOG.log(Level.WARNING, "JAXWS_ANNOTATION_FOUND", serviceClass.getName());*
from WARNING to INFO level? 
>   According to the code below, it looks like these logging message prints out the INFO
level information, and it is not a warning. A warning message will involve supporting team
to receive alert so we want to avoid it.
>   Could you please relax it? thanks.
> David
> {code}
>       protected void checkServiceClassAnnotations(Class<?> sc) {
>         Annotation anns[] = serviceClass.getAnnotations();
>         if (anns != null) {
>             for (Annotation ann : anns) {
>                 String pkg = ann.annotationType().getPackage().getName(); 
>                 if ("javax.xml.ws".equals(pkg)
>                     || "javax.jws".equals(pkg)) {
>                     
>                     LOG.log(Level.WARNING, "JAXWS_ANNOTATION_FOUND", serviceClass.getName());
>                     return;
>                 }
>             }
>         }
>         for (Method m : serviceClass.getMethods()) {
>             anns = m.getAnnotations();
>             if (anns != null) {
>                 for (Annotation ann : anns) {
>                     String pkg = ann.annotationType().getPackage().getName(); 
>                     if ("javax.xml.ws".equals(pkg)
>                         || "javax.jws".equals(pkg)) {
>                         
>                         LOG.log(Level.WARNING, "JAXWS_ANNOTATION_FOUND", serviceClass.getName());
>                         return;
>                     }
>                 }
>             }
>         }
>     }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message