cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Metcalf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-3492) Spring OSGI Service Reference as JAXWS:endpoint implementor
Date Thu, 05 May 2011 23:45:03 GMT

    [ https://issues.apache.org/jira/browse/CXF-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029656#comment-13029656
] 

David Metcalf commented on CXF-3492:
------------------------------------

Thanks Ed & Dan,

These were my final changes  (apologies for mistakes in the initial analysis - was a long
week):

{{diff apache-cxf-2.4.0-src/common/common/src/main/java/org/apache/cxf/common/util/SpringAopClassHelper.java
apache-cxf-2.4.0-src.patched/common/common/src/main/java/org/apache/cxf/common/util/SpringAopClassHelper.java}}
{code}
58c58
<         if (AopUtils.isAopProxy(o)) {
---
>         if (AopUtils.isAopProxy(o) && (o instanceof Advised)) {
{code}

(May be better if it logs something when skipping over an unadvised proxy, but not sure it
matters.)


{{diff apache-cxf-2.4.0-src/rt/frontend/simple/src/main/java/org/apache/cxf/frontend/ServerFactoryBean.java
apache-cxf-2.4.0-src.patched/rt/frontend/simple/src/main/java/org/apache/cxf/frontend/ServerFactoryBean.java}}
{code}
179c179
<             if (serviceBean != null) {
---
>             if (serviceBean != null && getServiceClass() == null) {
187c187
<     
---
>    
191,192c191,195
<                                               ? getServiceFactory().getServiceClass()
: getServiceClass()
<                                               : ClassHelper.getRealClass(getServiceBean()));
---
>                                               ? getServiceFactory().getServiceClass()

>                                               : getServiceClass()
>                                           : getServiceClass() == null
>                                               ? ClassHelper.getRealClass(getServiceBean())

>                                               : getServiceClass());
329c332
< }
{code}

Patch contributed under CXF's license http://www.apache.org/licenses/LICENSE-2.0.txt


Kind Regards,
David Metcalf.

> Spring OSGI Service Reference as JAXWS:endpoint implementor
> -----------------------------------------------------------
>
>                 Key: CXF-3492
>                 URL: https://issues.apache.org/jira/browse/CXF-3492
>             Project: CXF
>          Issue Type: Bug
>          Components: OSGi
>    Affects Versions: 2.4
>            Reporter: Edward Ost
>         Attachments: ServerFactoryBean.java, SpringAopClassHelper.java
>
>
> Problem pointing <jaxws:endpoint> to an implementor that's provided by <osgi:reference>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message