Return-Path: 
 <issues-return-16606-apmail-cxf-issues-archive=cxf.apache.org@cxf.apache.org>
Delivered-To: apmail-cxf-issues-archive@www.apache.org
Received: (qmail 4639 invoked from network); 6 Apr 2011 08:56:50 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 6 Apr 2011 08:56:50 -0000
Received: (qmail 2965 invoked by uid 500); 6 Apr 2011 08:56:50 -0000
Delivered-To: apmail-cxf-issues-archive@cxf.apache.org
Received: (qmail 2912 invoked by uid 500); 6 Apr 2011 08:56:45 -0000
Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cxf.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cxf.apache.org>
List-Post: <mailto:issues@cxf.apache.org>
List-Id: <issues.cxf.apache.org>
Reply-To: dev@cxf.apache.org
Delivered-To: mailing list issues@cxf.apache.org
Received: (qmail 2840 invoked by uid 99); 6 Apr 2011 08:56:43 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2011 08:56:43 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2011 08:56:42 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id C1E4D94332
	for <issues@cxf.apache.org>; Wed,  6 Apr 2011 08:56:05 +0000 (UTC)
Date: Wed, 6 Apr 2011 08:56:05 +0000 (UTC)
From: "Willem Jiang (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: 
 <1133933403.37360.1302080165790.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Created] (CXF-3442) SAAJInInterceptor should not swallow
 the exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

SAAJInInterceptor should not swallow the exception
--------------------------------------------------

                 Key: CXF-3442
                 URL: https://issues.apache.org/jira/browse/CXF-3442
             Project: CXF
          Issue Type: Improvement
          Components: Soap Binding
            Reporter: Willem Jiang
            Assignee: Willem Jiang
            Priority: Minor
             Fix For: 2.4, 2.3.4


When sending an invalid SOAP message specifically with an incorrect end tag:
{code}
snip...
  <soapenv:Body>
      <cus:lookupCustomer>
         <customerId>1</customerId>
         <customerId2>1</customerId2>
      <cus:lookupCustomer>   <------- no slash.
   </soapenv:Body>
end snip..
{code}
The wrong SOAP fault is thrown when using the WSS4JInInterceptor:
{code}
<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
   <soap:Body>
      <soap:Fault>
         <faultcode>soap:Client</faultcode>
         <faultstring>Problems creating SAAJ object model</faultstring>
      </soap:Fault>
   </soap:Body>
</soap:Envelope>
{code}
When the WSS4JInInterceptor is removed the following exception is thrown:
{code}
<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
   <soap:Body>
      <soap:Fault>
         <faultcode>soap:Client</faultcode>
         <faultstring>Unmarshalling Error: cvc-complex-type.2.4.d: Invalid content was found starting with element 'cus:lookupCustomer'. No child element is expected at this point.</faultstring>
      </soap:Fault>
   </soap:Body>
</soap:Envelope>
{code}

If you enable the WSS4JInInterceptor, CXF will use SAAJInInterceptor to create a SOAP message for using.
That could explain that you got the "Problems creating SAAJ object model" message.
I just checked the code of SAAJInInterceptor, it just wrap the real cause of exception message like this
{code}
} catch (SOAPException soape) {
            throw new SoapFault(new org.apache.cxf.common.i18n.Message(
                    "SOAPHANDLERINTERCEPTOR_EXCEPTION", BUNDLE), soape,
                    message.getVersion().getSender());
        } catch (XMLStreamException e) {
            throw new SoapFault(new org.apache.cxf.common.i18n.Message(
                    "SOAPHANDLERINTERCEPTOR_EXCEPTION", BUNDLE), e, message
                    .getVersion().getSender());
        }
{code}
To make sure the CXF client can get the exception message rightly, I think we just let the SAAJInInterceptor use the exception message directly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira