cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-3344) Runtime Exceptions should not be wrapped. Exceptions should not be logged and rethrown in AbstractFaultChainInitiatorObserver
Date Thu, 17 Feb 2011 13:03:24 GMT

    [ https://issues.apache.org/jira/browse/CXF-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995796#comment-12995796
] 

Christian Schneider commented on CXF-3344:
------------------------------------------

The current block of code is this:
try {
    chain.doIntercept(faultMessage);
} catch (Exception exc) {
    LOG.log(Level.SEVERE, "Error occurred during error handling, give up!", exc);
    throw new RuntimeException(exc);
}

As chain does not throw checked exceptions and I would like to only rethrow and not log we
could simply skip the handling:

chain.doIntercept(faultMessage);

What do you others think? Did I overlook something or can it be that simple


> Runtime Exceptions should not be wrapped. Exceptions should not be logged and rethrown
in AbstractFaultChainInitiatorObserver
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3344
>                 URL: https://issues.apache.org/jira/browse/CXF-3344
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Christian Schneider
>
> Currently the class org.apache.cxf.interceptor.AbstractFaultChainInitiatorObserver handles
faults and sends them to a chain.
> If in this chain another exception occurs then three things happen.
> 1) The exception is Wrapped in a RuntimeException
> 2) The exception is logged
> 3) The exception is rethrown
> I propose to do the following instead :
> 1) Only Wrap the exception if it is no RuntimeException
> 2) Simply Rethrow and do not log as probably the Exception in caught and logged in another
place anyway

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message