cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Kulp (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (CXF-3302) org.codehaus.xfire reference missed in Aegis AnnotationReader
Date Wed, 02 Feb 2011 12:31:29 GMT

    [ https://issues.apache.org/jira/browse/CXF-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989615#comment-12989615
] 

Daniel Kulp edited comment on CXF-3302 at 2/2/11 12:29 PM:
-----------------------------------------------------------

The original code is correct.   It's supposed to be detecting if the older XFire annotations
are available and will use them if they are.   If you trace through the load method, it catches
Throwable from the Class.forName and returns null.   Thus, I cannot see how this can be an
issue.

Also, since those classes are NOT available in any of the CXF test suites, if it was an issue,
none of the CXF tests would work.   Thus, I'm not sure why it could be causing an issue for
you.




      was (Author: dkulp):
    
The original code is correct.   It's supposed to be detexting if the older XFire annotations
are available and will use them if they are.   If you trace through the load method, it catches
Throwable from the Class.forName and returns null.   Thus, I cannot see how this can be an
issue.

Also, since those classes are NOT available in any of the CXF test suites, if it was an issue,
none of the CXF tests would work.   Thus, I'm not sure why it could be causing an issue for
you.



  
> org.codehaus.xfire reference missed in Aegis AnnotationReader
> -------------------------------------------------------------
>
>                 Key: CXF-3302
>                 URL: https://issues.apache.org/jira/browse/CXF-3302
>             Project: CXF
>          Issue Type: Bug
>          Components: Aegis Databinding
>    Affects Versions: 2.3.1, 2.3.2
>            Reporter: Matt Cary
>            Priority: Critical
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> org.apache.cxf.aegis.type.java5.AnnotationReader contains string references to org.codehaus.xfire
packaged classes.  These references are used in Class.forName() which then generates a ClassNotFound
error.
> Patch:
> {noformat}
> Index: rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/AnnotationReader.java
> ===================================================================
> --- rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/AnnotationReader.java
(revision )
> +++ rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/type/java5/AnnotationReader.java
(revision )
> @@ -43,17 +43,17 @@
>              load("javax.xml.bind.annotation.XmlTransient");
>  
>      private static final Class<? extends Annotation> XFIRE_IGNORE_PROPERTY =
> -            load("org.codehaus.xfire.aegis.type.java5.IgnoreProperty");
> +            load("org.apache.cxf.aegis.type.java5.IgnoreProperty");
>      private static final Class<? extends Annotation> XFIRE_XML_ATTRIBUTE =
> -        load("org.codehaus.xfire.aegis.type.java5.XmlAttribute");
> +            load("org.apache.cxf.aegis.type.java5.XmlAttribute");
>      private static final Class<? extends Annotation> XFIRE_XML_ELEMENT =
> -        load("org.codehaus.xfire.aegis.type.java5.XmlElement");
> +            load("org.apache.cxf.aegis.type.java5.XmlElement");
>      private static final Class<? extends Annotation> XFIRE_XML_TYPE =
> -        load("org.codehaus.xfire.aegis.type.java5.XmlType");
> +            load("org.apache.cxf.aegis.type.java5.XmlType");
>      private static final Class<? extends Annotation> XFIRE_XML_PARAM_TYPE =
> -        load("org.codehaus.xfire.aegis.type.java5.XmlParamType");
> +            load("org.apache.cxf.aegis.type.java5.XmlParamType");
>      private static final Class<? extends Annotation> XFIRE_XML_RETURN_TYPE =
> -        load("org.codehaus.xfire.aegis.type.java5.XmlReturnType");
> +            load("org.apache.cxf.aegis.type.java5.XmlReturnType");
>  
>  
>      @SuppressWarnings("unchecked")
> {noformat}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message