cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (CXF-3145) Refactor toSQL method as visitor pattern
Date Mon, 17 Jan 2011 13:45:46 GMT

     [ https://issues.apache.org/jira/browse/CXF-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sergey Beryozkin resolved CXF-3145.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4
         Assignee: Sergey Beryozkin

Hi Brian - I've finally managed to look at this issue. I've committed the patch with few minor
changes.

http://svn.apache.org/viewvc?rev=1059923&view=rev

This is a breaking change so it will be limited to 2.4.0.

Thanks 

> Refactor toSQL method as visitor pattern
> ----------------------------------------
>
>                 Key: CXF-3145
>                 URL: https://issues.apache.org/jira/browse/CXF-3145
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 2.3.0
>            Reporter: Brian Topping
>            Assignee: Sergey Beryozkin
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: cxf3145.patch
>
>
> In doing some work with the FIQL parser, I needed to generate a different output than
SQL.  By using a visitor pattern for rendering the SQL, any visitor can be applied to the
SearchCondition object graph.
> The attached patch provides that refactoring. 
> As a part of that, SearchCondition.toSql() is deprecated, but I maintained the interface
for maximum compatibility.  
> There was also a change to SearchCondition.getSearchConditions().  There were no callers
to that code except test code, and it was set up to return null if there was only one condition.
 That wasn't clear to me, hopefully that change is not unreasonable.
> This may not be formatted properly, please adjust to suit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message