Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Message-ID: <4049875.36011291756290721.JavaMail.jira@thor>
Date: Tue, 7 Dec 2010 16:11:30 -0500 (EST)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Subject: [jira] Commented: (CXF-3160) Reduce Code duplication between http
 transport variants
In-Reply-To: <14264343.56961291241771250.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CXF-3160?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D129689=
90#action_12968990 ]=20

Christian Schneider commented on CXF-3160:
------------------------------------------

Dan,

so at runtime the cxf bundle has no access to the classes of the applicatio=
n?  I guess this is quite normal in osgi. I somehow doubt that messing with=
 the classloader will really make things better. Isn=C2=B4t there a more os=
gi like way to solve this problem? At some point the application will confi=
gure the service endpoint in it=C2=B4s spring config. At this point the cla=
ssloader of the service provider should be available. So we could easily in=
ject the properties into the endpoint config. Isn=C2=B4t the spring osgi ex=
tender already tweaking the classloaders for us here?

Btw. I have done some more refactoring that I almost had committed as the b=
uild worked nicely on my machine. Then I realized that I did not change any=
 osgi spring configs. So they did not really work anymore. Still the build =
worked. So am I right that we have no system tests for osgi in the build? I=
f I am correct then I think we should add at least some basic tests to make=
 sure the configs are correct.

Christian


> Reduce Code duplication between http transport variants
> -------------------------------------------------------
>
>                 Key: CXF-3160
>                 URL: https://issues.apache.org/jira/browse/CXF-3160
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.3.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>         Attachments: CXF-3160-1.patch, CXF-3160-2.patch
>
>
> We still have to much duplicated or very similar code in the http transpo=
rts.=20
> Moving header code from AbstractHttpDestination to Headers
> Moving invokeDestination from ServletController to AbstractServletControl=
ler to share this code with http-osgi
> Moving invoke from ServletDestination to AbstractHttpDestination  to shar=
e this code with http-osgi
> Removing doMessage from OsgiDestination
> Removing invokeDestination from OsgiServletcontroller
> Ignoring some mock based tests that do not work anymore. Will have to do =
some work on them
> There are some small changes in the behaviour for http-osgi as we are now=
 using the servlet code here. It would be great if Sergey or Dan could revi=
ew this. Idon=C2=B4t think the differences are important but I am not sure.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.