cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-3160) Reduce Code duplication between http transport variants
Date Tue, 07 Dec 2010 21:11:30 GMT

    [ https://issues.apache.org/jira/browse/CXF-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968990#action_12968990
] 

Christian Schneider commented on CXF-3160:
------------------------------------------

Dan,

so at runtime the cxf bundle has no access to the classes of the application?  I guess this
is quite normal in osgi. I somehow doubt that messing with the classloader will really make
things better. Isn´t there a more osgi like way to solve this problem? At some point the
application will configure the service endpoint in it´s spring config. At this point the
classloader of the service provider should be available. So we could easily inject the properties
into the endpoint config. Isn´t the spring osgi extender already tweaking the classloaders
for us here?

Btw. I have done some more refactoring that I almost had committed as the build worked nicely
on my machine. Then I realized that I did not change any osgi spring configs. So they did
not really work anymore. Still the build worked. So am I right that we have no system tests
for osgi in the build? If I am correct then I think we should add at least some basic tests
to make sure the configs are correct.

Christian


> Reduce Code duplication between http transport variants
> -------------------------------------------------------
>
>                 Key: CXF-3160
>                 URL: https://issues.apache.org/jira/browse/CXF-3160
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.3.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>         Attachments: CXF-3160-1.patch, CXF-3160-2.patch
>
>
> We still have to much duplicated or very similar code in the http transports. 
> Moving header code from AbstractHttpDestination to Headers
> Moving invokeDestination from ServletController to AbstractServletController to share
this code with http-osgi
> Moving invoke from ServletDestination to AbstractHttpDestination  to share this code
with http-osgi
> Removing doMessage from OsgiDestination
> Removing invokeDestination from OsgiServletcontroller
> Ignoring some mock based tests that do not work anymore. Will have to do some work on
them
> There are some small changes in the behaviour for http-osgi as we are now using the servlet
code here. It would be great if Sergey or Dan could review this. Idon´t think the differences
are important but I am not sure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message