cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Kulp (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-3160) Reduce Code duplication between http transport variants
Date Thu, 02 Dec 2010 22:46:11 GMT

    [ https://issues.apache.org/jira/browse/CXF-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966322#action_12966322
] 

Daniel Kulp commented on CXF-3160:
----------------------------------



Christian,

I recently (tuesday) found out that the SpringOsgiServlet was setting the context classloader
wrong anyway.  Thus, that is kind of irrelevant.   Basically, it was setting it to the classloader
of the CXF-bundle, not of the application.  Thus, it wasn't usable to find any of hte  security
related things anyway.  I added some code to the some of the other classes to  get  the right
classloader, so defintely take that into account.

I think in OSGi, the servlet can only be registered on a single context, so it didn't need
to  take into account multiple contexts.   The Servlet one does.   That said, it could check,
it would just always match.  

Refactoring out the Service list and such is great.   (honestly, I'd love to just move that
and the wsdl generation into interceptors, but that's a different story so you could even
do a "GET" type thing over JMS to get them like we handle the JAX-RS over JMS things.)



> Reduce Code duplication between http transport variants
> -------------------------------------------------------
>
>                 Key: CXF-3160
>                 URL: https://issues.apache.org/jira/browse/CXF-3160
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.3.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>         Attachments: CXF-3160-1.patch
>
>
> We still have to much duplicated or very similar code in the http transports. 
> Moving header code from AbstractHttpDestination to Headers
> Moving invokeDestination from ServletController to AbstractServletController to share
this code with http-osgi
> Moving invoke from ServletDestination to AbstractHttpDestination  to share this code
with http-osgi
> Removing doMessage from OsgiDestination
> Removing invokeDestination from OsgiServletcontroller
> Ignoring some mock based tests that do not work anymore. Will have to do some work on
them
> There are some small changes in the behaviour for http-osgi as we are now using the servlet
code here. It would be great if Sergey or Dan could review this. IdonĀ“t think the differences
are important but I am not sure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message