cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-3160) Reduce Code duplication between http transport variants
Date Sun, 05 Dec 2010 13:00:13 GMT

    [ https://issues.apache.org/jira/browse/CXF-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966939#action_12966939
] 

Sergey Beryozkin commented on CXF-3160:
---------------------------------------

Hi Christian

the changes look fine and reasonable - difficult to see if they can affect the existing demos.
They look ok. Dan may have something else to say. 

You may want to try the changes later on againt some ServiceMix demos (say a soap cxf-osgi
and the old cxf-jaxrs demo), by replacing the CXF bundle ServiceMix ships in (system folder)
with the one containing your changes. 

cheers, Sergey 

> Reduce Code duplication between http transport variants
> -------------------------------------------------------
>
>                 Key: CXF-3160
>                 URL: https://issues.apache.org/jira/browse/CXF-3160
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.3.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>         Attachments: CXF-3160-1.patch, CXF-3160-2.patch
>
>
> We still have to much duplicated or very similar code in the http transports. 
> Moving header code from AbstractHttpDestination to Headers
> Moving invokeDestination from ServletController to AbstractServletController to share
this code with http-osgi
> Moving invoke from ServletDestination to AbstractHttpDestination  to share this code
with http-osgi
> Removing doMessage from OsgiDestination
> Removing invokeDestination from OsgiServletcontroller
> Ignoring some mock based tests that do not work anymore. Will have to do some work on
them
> There are some small changes in the behaviour for http-osgi as we are now using the servlet
code here. It would be great if Sergey or Dan could review this. IdonĀ“t think the differences
are important but I am not sure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message