cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <>
Subject [jira] Commented: (CXF-3160) Reduce Code duplication between http transport variants
Date Sun, 05 Dec 2010 20:59:11 GMT


Christian Schneider commented on CXF-3160:

I have committed my second patch now. The tests seem to run fine.

I have a question about the change in the class loader inside OsgiServletController that you
did. Could you explain what classes or ressources were not reachable before and how it works
What I also wonder is why you set the classloader for the normal services and the queryhandlers
but not for the jaxrs services?

I also do not yet really understand what the queryhandlers are used for. Can anyone shed some
light on this? I just did some research and found the JavascriptQueryHandler and the WSDLQueryhandler.
Are they the only known implementations?

Anyway I wonder if we could treat the service listing like a queryhandler. I am even wondering
if the destinations could also be selected in this way. Currently we are having different
code for queryhandlers, service listing, soap and jaxrs services. 
I could imagine the qh.isRecognizedQuery(baseUri, ctxUri, ei) we use for the queryhandlers
could be generally used for destinations. So all four cases could be either different kinds
of destinations or queryhandlers. What do you think about this?

Another thing I don´t understand is what the method udatedests is good for. I guess it saves
the combination of basepath of the servlet and relative path that was configured on the endpoint.
What I don´t understand though is why it is called everytime and not only when doing initializations.
The method also seems to behave different in the jetty case. I guess because there can be
several base paths.

> Reduce Code duplication between http transport variants
> -------------------------------------------------------
>                 Key: CXF-3160
>                 URL:
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.3.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>         Attachments: CXF-3160-1.patch, CXF-3160-2.patch
> We still have to much duplicated or very similar code in the http transports. 
> Moving header code from AbstractHttpDestination to Headers
> Moving invokeDestination from ServletController to AbstractServletController to share
this code with http-osgi
> Moving invoke from ServletDestination to AbstractHttpDestination  to share this code
with http-osgi
> Removing doMessage from OsgiDestination
> Removing invokeDestination from OsgiServletcontroller
> Ignoring some mock based tests that do not work anymore. Will have to do some work on
> There are some small changes in the behaviour for http-osgi as we are now using the servlet
code here. It would be great if Sergey or Dan could review this. Idon´t think the differences
are important but I am not sure.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message