Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Message-ID: <18029432.225921290384314451.JavaMail.jira@thor>
Date: Sun, 21 Nov 2010 19:05:14 -0500 (EST)
From: "Brian Topping (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Subject: [jira] Updated: (CXF-3145) Refactor toSQL method as visitor pattern
In-Reply-To: <2375411.225901290384074443.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CXF-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Topping updated CXF-3145:
-------------------------------

    Attachment: cxf3145.patch

> Refactor toSQL method as visitor pattern
> ----------------------------------------
>
>                 Key: CXF-3145
>                 URL: https://issues.apache.org/jira/browse/CXF-3145
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 2.3.0
>            Reporter: Brian Topping
>            Priority: Minor
>         Attachments: cxf3145.patch
>
>
> In doing some work with the FIQL parser, I needed to generate a different output than SQL.  By using a visitor pattern for rendering the SQL, any visitor can be applied to the SearchCondition object graph.
> The attached patch provides that refactoring. 
> As a part of that, SearchCondition.toSql() is deprecated, but I maintained the interface for maximum compatibility.  
> There was also a change to SearchCondition.getSearchConditions().  There were no callers to that code except test code, and it was set up to return null if there was only one condition.  That wasn't clear to me, hopefully that change is not unreasonable.
> This may not be formatted properly, please adjust to suit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.