cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Liguori (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (CXF-3102) Update Apache CXF's main pom.xml file
Date Fri, 29 Oct 2010 21:06:25 GMT

    [ https://issues.apache.org/jira/browse/CXF-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926455#action_12926455
] 

Robert Liguori edited comment on CXF-3102 at 10/29/10 5:06 PM:
---------------------------------------------------------------

Maven organizes the ordering of their pom elements based on what makes the most logical sense,
flow-wise.  That is, there is value here in the organization as well as for those who strive
to follow the standard (if you want to call it a standard), as they will expect the elements
to be organized this way.

BTW, re-organizing from scratch is a 5 minute task... so if it's a trust thing... any developer
can do it themselves if they want to refine the pom for CXF.

Plugin updates really aren't debatable (when tested), nor is adding a description element;
 I think they should be done.

Empty tags... sure, if there is no logical sense to ever have these tags, then exclude them...
otherwise the tags would simply be flags for future improvements/enhancements to the pom.

Formatting (aligning tags that are out of place)... only brings value and cannot cause functional
changes.

In regards to the "parent element"... I have no idea what this does, that is why I didn't
add it.

...just my thoughts.



      was (Author: gliesian):
    Maven organizes the ordering of their pom elements based on what makes the most logical
sense, flow-wise.  That is, there is value here in the organization as well as for those who
strive to follow the standard (if you want to call it a standard), as they will expect the
elements to be organized this way.

BTW, organizing from scratch is a 5 minute task... so if it's a trust thing... any developer
can do it themselves if they want to refine the pom for CXF.

Plugin updates really aren't debatable (when tested), nor is adding a description element;
 I think they should be done.

Empty tags... sure, if there is no logical sense to ever have these tags, then exclude them...
otherwise the tags would simply be flags for future improvements/enhancements to the pom.

Formatting (aligning tags that are out of place)... only brings value and cannot cause functional
changes.

In regards to the "parent element"... I have no idea what this does, that is why I didn't
add it.

...just my thoughts.


  
> Update Apache CXF's main pom.xml file
> -------------------------------------
>
>                 Key: CXF-3102
>                 URL: https://issues.apache.org/jira/browse/CXF-3102
>             Project: CXF
>          Issue Type: Improvement
>          Components: Build system
>    Affects Versions: 2.3.0
>            Reporter: Robert Liguori
>            Priority: Minor
>         Attachments: pom.xml, pom_diff.txt
>
>
> Familiarizing myself with Apache's CXF's build process, I made a few refinements to the
main pom.xml file (note: testing is needed on these changes).
> Below are descriptions of the changes, the updated pom.xml from the CXF 2.3.0 project
and a diff file between the old and new pom.xml files are attached.
> The refinements:
> 1) Reorganized elements relative to Maven project descriptor reference: http://maven.apache.org/ref/2.2.1/maven-model/maven.html
> 2) Added "description" element.  Note: This description should be expanded by someone
more versed in CXF's main features.
> 3) Added empty elements where there is no present content.
> 4) Made the following versioning changes:
> Updated maven-project-info-reports-plugin from 2.1.1 to 2.2.  
> Referenece: http://maven.apache.org/plugins/maven-project-info-reports-plugin/jira-report.html
> Updated maven-javadoc-plugin from 2.6 to 2.7.  
> Reference: http://maven.apache.org/plugins/maven-javadoc-plugin/jira-report.html
> Updated maven-release-plugin from 2.0 to 2.1. 
> Reference: http://maven.apache.org/plugins/maven-release-plugin/usage.html
> 5) Performed formatting using NetBeans default XML formatting settings.
> 6) Question: Shouldn't there be a parent element?  I made no changes here, but think
that there should be.
> Note: If you open up the attached pom.xml file in Firefox, you will not see the applied
spacing (but it's there).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message