cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benson Margulies (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-3102) Update Apache CXF's main pom.xml file
Date Fri, 29 Oct 2010 20:42:23 GMT

    [ https://issues.apache.org/jira/browse/CXF-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926449#action_12926449
] 

Benson Margulies commented on CXF-3102:
---------------------------------------

Do Not add a parent element. org.apache:apache:7 has bad things in it which we don't like.
The POM structure in CXF was lovingly crafted by Dan with occasional grace-notes from others.

It would be better not to reformat in this sort of patch, since it makes it hard to read the
diffs, and I do not think that empty elements are desirable at all.

Personally, I use xmllint on Linux or MacOSX when a pom needs a format cleanup.



> Update Apache CXF's main pom.xml file
> -------------------------------------
>
>                 Key: CXF-3102
>                 URL: https://issues.apache.org/jira/browse/CXF-3102
>             Project: CXF
>          Issue Type: Improvement
>          Components: Build system
>    Affects Versions: 2.3.0
>            Reporter: Robert Liguori
>            Priority: Minor
>         Attachments: pom.xml, pom_diff.txt
>
>
> Familiarizing myself with Apache's CXF's build process, I made a few refinements to the
main pom.xml file (note: testing is needed on these changes).
> Below are descriptions of the changes, the updated pom.xml from the CXF 2.3.0 project
and a diff file between the old and new pom.xml files are attached.
> The refinements:
> 1) Reorganized elements relative to Maven project descriptor reference: http://maven.apache.org/ref/2.2.1/maven-model/maven.html
> 2) Added "description" element.  Note: This description should be expanded by someone
more versed in CXF's main features.
> 3) Added empty elements where there is no present content.
> 4) Made the following versioning changes:
> Updated maven-project-info-reports-plugin from 2.1.1 to 2.2.  
> Referenece: http://maven.apache.org/plugins/maven-project-info-reports-plugin/jira-report.html
> Updated maven-javadoc-plugin from 2.6 to 2.7.  
> Reference: http://maven.apache.org/plugins/maven-javadoc-plugin/jira-report.html
> Updated maven-release-plugin from 2.0 to 2.1. 
> Reference: http://maven.apache.org/plugins/maven-release-plugin/usage.html
> 5) Performed formatting using NetBeans default XML formatting settings.
> 6) Question: Shouldn't there be a parent element?  I made no changes here, but think
that there should be.
> Note: If you open up the attached pom.xml file in Firefox, you will not see the applied
spacing (but it's there).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message