cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ate Douma (JIRA)" <>
Subject [jira] Commented: (CXF-2997) CXF JAX-RS not thread safe when accessing multiple destinations concurrently
Date Thu, 30 Sep 2010 09:54:37 GMT


Ate Douma commented on CXF-2997:

Hi Sergey,

I finally found time to test your fix, for which I tried both the 2.2.x-fixes branch and 2.3.0-SNAPSHOT

With the 2.2.x-fixes branch, I ran my test webapp as previously attached to this issue (adjusted
to use cxf 2.2.11-SNAPSHOT) and adding init-param disable-address-updates=true on CXFServlet.
This now seems to works!
Note, even if you only have one servlet (mapping) configured this disable-address-updates
parameter is required to be set if you access the endpoints through multiple host names (as
localhost and in my test app).

The current 2.3.0-SNAPSHOT trunk I couldn't test because it fails to build...
Note: I first (had to) build the cxf-build-utils and cxf-xjc-builds as the current apache
snapshot repository seems not to be up to date. 
Thereafter it get a compilation error on the generated cxf-api sources: 

cannot find symbol
    symbol: class TExtensibilityElement
    extends TExtensibilityElement

Shortly above this error is another suspicious error logged by cxf-xjc:xsdtojava: 
  [INFO] [cxf-xjc:xsdtojava {execution: generate-sources}]
  [ERROR] The declaration for the entity "ContentType" must end with '>'.
    line 81 of

Not sure if this is related and/or only an intermediate problem with the trunk?
Note: I'm building on Linux with maven 2.2.1 and Java 1.6.0_20-b02 (i386)  

> CXF JAX-RS not thread safe when accessing multiple destinations concurrently 
> -----------------------------------------------------------------------------
>                 Key: CXF-2997
>                 URL:
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS, Transports
>    Affects Versions: 2.2.10
>            Reporter: Ate Douma
>            Priority: Blocker
>             Fix For: 2.3, 2.2.11
>         Attachments: cxf-rest-test.tar.gz
> If a (single) JAX-RS service is invoked concurrently for different destinations, the
CXF ServletController and ServletTransportFactory implementations override the current Destination
state between these invocations.
> I have created a simple test web application using Spring to expose this problem.
> My example looks like:
> @Path("/myservice/")
> @Produces("application/xml")
> public class ServiceImpl {
>   volatile boolean locked;
>   @GET
>   @Path("/uris")
>   @Produces("text/plain")
>   public String getUris(@Context UriInfo uriInfo) {
>     StringBuilder uris = new StringBuilder("BaseUri on entry: "+uriInfo.getBaseUri().toString()).append("\n");
>     try {
>       while (locked) {
>         Thread.sleep(1000);
>       }
>     }  
>     catch (Exception x) {}
>     return uris.append("BaseUri on exit : " + uriInfo.getBaseUri().toString()).append("\n").toString();
>   }
>   @GET
>   @Path("/lock")
>   @Produces("text/plain")
>   public String lock() {
>     locked = true;
>     return "locked";
>   }
>   @GET
>   @Path("/unlock")
>   @Produces("text/plain")
>   public String unlock() {
>     locked = false;
>     return "unlocked";
>   }
> And in my web.xml I defined two CXFServlet mappings as follows:
>     <servlet-mapping>
>         <servlet-name>CXFServlet</servlet-name>
>         <url-pattern>/one/*</url-pattern>
>     </servlet-mapping>
>     <servlet-mapping>
>         <servlet-name>CXFServlet</servlet-name>
>         <url-pattern>/two/*</url-pattern>
>     </servlet-mapping>
> Finally, in Spring ApplicationContext.xml I setup the jaxrs server like this:
>     <jaxrs:server id="myService" address="/">
>         <jaxrs:serviceBeans>
>             <ref bean="serviceImpl" />
>         </jaxrs:serviceBeans>
>         <jaxrs:extensionMappings>
>             <entry key="xml" value="application/xml" />
>         </jaxrs:extensionMappings>
>     </jaxrs:server>
>     <bean id="serviceImpl" class="service.ServiceImpl" />
> As can be seen from the, I used a trick to temporarily "lock" and "unlock"
a call to /myservice/uris from another request using /myservice/lock and /myservice/unlock.
> Without locking, a call to http://localhost:8085/one/myservice/uris produces the expected
following result:
>   BaseUri on entry: http://localhost:8085/one/
>   BaseUri on exit : http://localhost:8085/two/
> However, if I first call http://localhost:8085/one/myservice/lock, then http://localhost:8085/one/myservice/uris
(blocked), and finally (note the different hostname and servletPath /two) I get the following result:
>   BaseUri on entry: http://localhost:8085/one/
>   BaseUri on exit :
> Clearly, UriInfo.getBaseURI() isn't thread safe as is shown above.
> After debugging a bit the current (CXF 2.2.10) implementation of the ServletController
and ServletTransportFactory, it looks like the ServletController.updateDests(HttpServletRequest)
method and the ServletTransportFactory as a whole don't maintain resolved Destination state
isolated per request.
> Our CXF (JAX-RS) application exposes the same REST service to be called from many different
addresses (hosts) as well as upfront unknown servlet paths, this really is a blocking issue.
> To be more concrete, we have to use a request wrapper to dynamically "mount" the same
rest service for different urls (its a front end for a unlimited hierarchical resources repository).

> Is there an easy way to protect JAX-RS service interactions from concurrent invocations,
e.g. by using special configurations, or is this indeed a serious bug which will have to be
fixed first? 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message