Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Message-ID: <25190750.11591271007761199.JavaMail.jira@thor>
Date: Sun, 11 Apr 2010 13:42:41 -0400 (EDT)
From: =?utf-8?Q?Bj=C3=B6rn_H=C3=A4user_=28JIRA=29?= <jira@apache.org>
To: issues@cxf.apache.org
Subject: [jira] Created: (CXF-2761) JavaScript variable "item" wont be
 reinitialized
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

JavaScript variable "item" wont be reinitialized
------------------------------------------------

                 Key: CXF-2761
                 URL: https://issues.apache.org/jira/browse/CXF-2761
             Project: CXF
          Issue Type: Bug
    Affects Versions: 2.2.7
         Environment: Mac OS X
            Reporter: Bj=C3=B6rn H=C3=A4user


Take a look at the generated JS-Code, and especially at the variable item.

{noformat}
function ws_ejb_core_lunchroulette_de__userGetMeetingpoints_deserialize (cx=
fjsutils, element) {
    var newobject =3D new ws_ejb_core_lunchroulette_de__userGetMeetingpoint=
s();
    cxfjsutils.trace('element: ' + cxfjsutils.traceElementName(element));
    var curElement =3D cxfjsutils.getFirstElementChild(element);
    var item;
    cxfjsutils.trace('curElement: ' + cxfjsutils.traceElementName(curElemen=
t));
    cxfjsutils.trace('processing session');
    var value =3D null;
    if (!cxfjsutils.isElementNil(curElement)) {
     value =3D cxfjsutils.getNodeText(curElement);
     item =3D value;
    }
    newobject.setSession(item);
    if (curElement !=3D null) {
     curElement =3D cxfjsutils.getNextElementSibling(curElement);
    }
    cxfjsutils.trace('curElement: ' + cxfjsutils.traceElementName(curElemen=
t));
    cxfjsutils.trace('processing filter');
    var value =3D null;
    if (!cxfjsutils.isElementNil(curElement)) {
     item =3D ws_ejb_core_lunchroulette_de__filter_deserialize(cxfjsutils, =
curElement);
    }
    newobject.setFilter(item);
    if (curElement !=3D null) {
     curElement =3D cxfjsutils.getNextElementSibling(curElement);
    }
    return newobject;
}
{noformat}

It is possible that item is filled with the value of the first "element" an=
d not changed for the second element, and so the second vlement will get th=
e value for the first element.


Easy fix (in my opinion):
{noformat}
        utils.appendLine("newobject." + accessorName + "(item);");
        utils.appendLine("var item =3D null;");
        if (!itemInfo.isArray()) {
            utils.startIf("curElement !=3D null");
            utils.appendLine("curElement =3D cxfjsutils.getNextElementSibli=
ng(curElement);");
            utils.endBlock();
        }
{noformat}

Line 661 and following in SchemaJavascriptBuilder.java.

Thanks in advance,
Bj=C3=B6rn

--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: htt=
ps://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira