cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Bosschaert (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DOSGI-67) Enable filters on DOSGi endpoints
Date Thu, 25 Mar 2010 13:57:27 GMT

    [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849700#action_12849700
] 

David Bosschaert commented on DOSGI-67:
---------------------------------------

Nice work Josh, I see you've included a sample as well.

I have one small comment. I see that you introduced a dependency on spring-test. If I understand
it correctly this is purely for the MockHttpServletRequest and MockHttpServletResponse.
It seems like these can also be implemented using EasyMock which is the mock framework that
is generally used in the tests...
Reason I'm a little cautious about spring-test is because the DOSGi system tests used to be
based on it but it caused interference with the spring bundles used by CXF-DOSGi itself, so
I've recently changed the system tests deps away from spring test to use Pax Exam. The interference
might not be a problem in your use of it but it would still be nice if we can reuse EasyMock
as it's already there...

Oh and finally, it would be nice if you could put a little bit of documentation around the
demo at the DOSGi docs wiki too.

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>            Assignee: Sergey Beryozkin
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff, dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The
attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply
to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message