cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-2541) JMX Per Operation ResponseTime not collected for JAX-RS services
Date Tue, 17 Nov 2009 12:24:39 GMT

    [ https://issues.apache.org/jira/browse/CXF-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778840#action_12778840
] 

Sergey Beryozkin commented on CXF-2541:
---------------------------------------

Thanks for attaching this list. However, as I said in the previous comment, there could be
(and I'm more or less sure there's some) user code out there which explicitly deals with getting
say JAXRS OperationResourceInfo out of the exchange and doing some custom work with it. Perhaps
there could be some similar custom JAXWS code too.

What is your opinion about the proposed alternatives, with the first one being similar to
what you suggested but which avoids changing the existing gets and puts. The only interceptor
which will have to be updated is AbstractMessageResponseTimeInterceptor as it will rely on
the shared interface.

I'd also like to explore the possibility of introducing management beans instead

thanks, Sergey



> JMX Per Operation ResponseTime not collected for JAX-RS services
> ----------------------------------------------------------------
>
>                 Key: CXF-2541
>                 URL: https://issues.apache.org/jira/browse/CXF-2541
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.2.3
>            Reporter: Cyrille Le Clerc
>         Attachments: usage-of-OperationInfo-and-OperationResourceInfo.log
>
>
> The JMX ResponseTimeFeature does not work on a per operation basis for JAXRS calls but
works on a per Service basis.
> My understanding is that it works on a per service basis because both o.a.c.jaxrs.JAXRSServiceImpl
and o.a.c.service.ServiceImpl implement the same o.a.c.service.Service interface and are indexed
in the Exchange map at the o.a.c.service.Service entry.
> On the other hand, it does not work on the per operation basis because o.a.c.jaxrs.model.OperationResourceInfo
and o.a.c.service.model.OperationInfo do not implement a shared interface. Thus, the ResponseTimeFeature
is specific to SOAP operations and can not handle JAXRS 'operations'.
> A fix could be to introduce a shared Operation interface, to make both OperationResourceInfo
and OperationInfo implement this interface and to us the interface as the key for the Exchange
map instead of the current OperationResourceInfo.class and OperationInfo.class.
> There are 30 "put()" & "get()" calls on OperationInfo.class. and 8 "put()" &
"get()" calls on OperationResourceInfo.class.
> I would be very pleased to propose a patch if the project is interested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message