cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Willem Jiang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-2265) JMS Test Suite.
Date Thu, 30 Jul 2009 02:52:14 GMT

    [ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736969#action_12736969
] 

Willem Jiang commented on CXF-2265:
-----------------------------------

Hi,

I reviewed you patch, and found there is a performance issue for your current MessageID pattern
implementation.

You create the a DefaultMessageListenerContainer per request,  as you know the DefaultMessageListenerContainer
has a thread pool to listen to the reply queue.
Since the MessageID is unique, you will create thousands of MessageListenerContainer if you
send out thousands of request, and I don't find the code of releasing the MessageListenerContainer.
  It can work for massive message sending.

I think it is OK for the Correlation ID pattern to use the MessageListenerContainer , since
it can use the CorrelationPerfix to filter the response message, and it is create per response
queue.

To resolved the performance issue, you have two way to do , one is  create the MessageListenerContainer
per reply destination ( It will not work for the temp queue), and using the correlation id
map for response message. The other is using the Spring template to send and receive the synchronized
message (which is a good way to handle the response time out issue). You can find some example
in camel-jms component's CamelTemplate. 

BTW , there is small issue of jms.xsd change.  I don't think change the jms.xsd about the
jms conduit's CoduitSelectorPrefix's default value is right , since it is optional, the default
value is meaningless.

Willem

> JMS Test Suite.
> ---------------
>
>                 Key: CXF-2265
>                 URL: https://issues.apache.org/jira/browse/CXF-2265
>             Project: CXF
>          Issue Type: Sub-task
>          Components: Soap Binding
>            Reporter: Liu Cong
>         Attachments: test-patch.txt, test-patch2.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) . 
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass
the JMS Test Suite.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message