Return-Path: 
 <issues-return-9746-apmail-cxf-issues-archive=cxf.apache.org@cxf.apache.org>
Delivered-To: apmail-cxf-issues-archive@www.apache.org
Received: (qmail 41438 invoked from network); 30 Mar 2009 18:54:11 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 30 Mar 2009 18:54:11 -0000
Received: (qmail 25154 invoked by uid 500); 30 Mar 2009 18:54:11 -0000
Delivered-To: apmail-cxf-issues-archive@cxf.apache.org
Received: (qmail 25125 invoked by uid 500); 30 Mar 2009 18:54:11 -0000
Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cxf.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cxf.apache.org>
List-Post: <mailto:issues@cxf.apache.org>
List-Id: <issues.cxf.apache.org>
Reply-To: dev@cxf.apache.org
Delivered-To: mailing list issues@cxf.apache.org
Received: (qmail 25115 invoked by uid 99); 30 Mar 2009 18:54:11 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Mar 2009 18:54:11 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Mar 2009 18:54:10 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 63661234C003
	for <issues@cxf.apache.org>; Mon, 30 Mar 2009 11:53:50 -0700 (PDT)
Message-ID: <412763058.1238439230393.JavaMail.jira@brutus>
Date: Mon, 30 Mar 2009 11:53:50 -0700 (PDT)
From: "Dennis Kieselhorst (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Subject: [jira] Commented: (CXF-2113) http:client configuration with Spring
 PropertyPlaceholderConfigurer
In-Reply-To: <83125563.1236953750606.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/CXF-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693875#action_12693875 ] 

Dennis Kieselhorst commented on CXF-2113:
-----------------------------------------

I tried to configure the ReceiveTimeout with a PropertyPlaceholder. It seems that this is also not possible at the moment.

> http:client configuration with Spring PropertyPlaceholderConfigurer
> -------------------------------------------------------------------
>
>                 Key: CXF-2113
>                 URL: https://issues.apache.org/jira/browse/CXF-2113
>             Project: CXF
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 2.1.4
>         Environment: any
>            Reporter: Sven Reinhardt
>            Priority: Minor
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> -Problem:
> changing configuration of proxy in conduit client with spring PropertyPlaceholderConfigurer
> -Backgound:
> to avoid rebuild of the application for differnt environments configurations are externalized in property files like this:
> <bean
> 	class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
> 	<property name="locations" value="classpath:ws_client.properties" />
> </bean>
> <http:conduit ... >
> 	<http:client 
> 		ProxyServer="${ws.client.ProxyServer}" 
> 		ProxyServerPort="${ws.client.ProxyServer}" />
> </http:conduit>
> ws_client.properties:
> ws.client.ProxyServer=proxy
> ws.client.ProxyServerPort=8080
> But this fails for two reasons:
> 1. 
> org.apache.cxf.transports.http.configuration.HTTPClientPolicy getProxyServerPort() is an integer
> ProxyServerPort="${ws.client.ProxyServer}" fails because the xml is validated in advance of the placeholder replacement (this might be a spring issue or else)
> it could work if there would be a setProxyServerPortStr(String port) mehode
> 2.
> if there is no proxy it cant be "undone" because
> org.apache.cxf.transport.http.HTTPConduit  getProxy(HTTPClientPolicy) only cheks ProxyServer via HTTPClientPolicy.isSetProxyServer for  null
> if properties are set to:
> ws.client.ProxyServer=
> ws.client.ProxyServerPort=0
> it results in a connection refused, because the empty String proxy does not exist
> if properties are commented out spring complains about it 
> - Proposed solution:
> add methode setProxyServerPortStr(String port)
> HTTPClientPolicy.isSetProxyServer also checks is proxyServer.length>0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.