cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-1991) Incomplete implementations of UriInfo and UriBuilder
Date Wed, 21 Jan 2009 09:58:59 GMT

    [ https://issues.apache.org/jira/browse/CXF-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665772#action_12665772
] 

Sergey Beryozkin commented on CXF-1991:
---------------------------------------

Hi Andy

Many thanks for this effort. I'll try to apply the patch asap.
As far as your test is concerned :

URI newUri = new UriBuilderImpl().uri(uri).path("/bar").path("baz/").path("/blah/").build();
assertEquals("URI is not built correctly", new URI("http://foo/bar/baz/blah"), newUri); 

java.lang.AssertionError: URI is not built correctly expected:<http://foo/bar/baz/blah>
but was:<http://foo/bar/baz//blah/> 

I think the last trailing slash in "http://foo/bar/baz//blah/" is actually correct., but there's
a bug for 'baz//'.
The last trailing slash can make a difference in matching, for ex

@Path("/bar") void bar() {}
@Path("/bar/") void bar2() {}

/bar/ will match both methods, but bar2() will be chosen as the @Path value has more literal
characters (candidates are sorted in descending order for this criteria)




> Incomplete implementations of UriInfo and UriBuilder
> ----------------------------------------------------
>
>                 Key: CXF-1991
>                 URL: https://issues.apache.org/jira/browse/CXF-1991
>             Project: CXF
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 2.1.3, 2.2
>            Reporter: Andrzej Michalec
>            Priority: Minor
>         Attachments: cxf-1991_20090121.patch
>
>
> Some useful methods like UriBuilder.path(Class), UriBuilder.path(Method) or UriInfo.getMatchedResources()
are not implemented so far.
> Since I am have my locally tuned versions of these classes I am going to provide patch
soon :)
> cheers,
> andy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message