cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-1991) Incomplete implementations of UriInfo and UriBuilder
Date Mon, 19 Jan 2009 18:09:59 GMT

    [ https://issues.apache.org/jira/browse/CXF-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665171#action_12665171
] 

Sergey Beryozkin commented on CXF-1991:
---------------------------------------

Hi Andy

Can you please update your code to interact with a Message instance instead ? I'd prefer to
have JAXRS impl classes be unaware of things like JAXRSInvoker...For ex, we might let people
to provide custom invoker implementations, similarly to JAXWS runtime. Rather than having
UriInfo be aware of JAXRSInvoker, it would check a message instead, this is a typical pattern
in CXF.
For example, in JAXRSInvoker, before an invocation/injection is done, do something like :

message.put("MATCHED_OPERATIONS", oris);

and then in UriInfo you'll do message.get();

At the moment there's no central place for keeping key definitions like MATCHED_OPERATIONS,
some of them are kept in JAXRSInInterceptor which is really a wrong place for then. Perhaps
it's time to inroduce some JAXRSConstants class.

This way, you can just add some test into JAXRSUtilsTest, or create a new test suite altogether
and work with a Message(Impl) only.

In system tests once cam also bootstrap a server, either programmatically or from Spring.
See systests/.../jaxrs/JAXRSClientServerBookTest for an example of the former approach and
other tests for the example of the latter one


Cheers, Sergey

> Incomplete implementations of UriInfo and UriBuilder
> ----------------------------------------------------
>
>                 Key: CXF-1991
>                 URL: https://issues.apache.org/jira/browse/CXF-1991
>             Project: CXF
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 2.1.3, 2.2
>            Reporter: Andrzej Michalec
>            Priority: Minor
>
> Some useful methods like UriBuilder.path(Class), UriBuilder.path(Method) or UriInfo.getMatchedResources()
are not implemented so far.
> Since I am have my locally tuned versions of these classes I am going to provide patch
soon :)
> cheers,
> andy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message